RSDK-10618: fixing deadlock in managedProcess when Stop is called before Start #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For security reasons, this PR must be labeled with |
cheukt
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR for this ticket (#432) changed the behavior of
managedProcess.Stopso that all calls toStopwould block on the management channel closing instead of just the fist one. Unfortunately this causes a deadlock ifStopis called beforeStart. We have a test for this but for some reason it did not cause the CI runs on the PR to fail and instead only failed when the PR was merged. I'll dig into that later but for now this hotfix adds a check to make sure the process was started before blocking on the management channel inStop.