Skip to content

RSDK-10618: fixing deadlock in managedProcess when Stop is called before Start #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

RSDK-10618: fixing deadlock in managedProcess when Stop is called before Start #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pexec/managed_process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,12 @@ func (p *managedProcess) Stop() error {
select {
case <-p.killCh:
p.mu.Unlock()
<-p.managingCh
if p.cmd != nil {
// Avoid deadlocking if Stop was called before Start while blocking all
// calls to Stop that follow Start until the management goroutine shuts
// down.
<-p.managingCh
}
return nil
default:
}
Expand Down
Loading