[RSDK-10127] Add get and update metadata functions #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested changes
Mar 18, 2025
lib/src/app/app.dart
Outdated
| /// Retrieves user-defined [Metadata] for an organization. | ||
| /// | ||
| /// For more information, see [Fleet Management API](https://docs.viam.com/appendix/apis/fleet/). | ||
| Future<GetOrganizationMetadataResponse> getOrganizationMetadata(String id) async { |
There was a problem hiding this comment.
(minor/nit) can we rename to organizationId or orgId? it's more specific and more consistent with similar calls elsewhere in the SDK.
Same comment applies to below methods.
There was a problem hiding this comment.
great catch, thanks for calling this out
lib/src/app/app.dart
Outdated
| Future<void> updateOrganizationMetadata(String id, Map<String, dynamic> data) async { | ||
| final request = UpdateOrganizationMetadataRequest() | ||
| ..organizationId = id | ||
| ..data = _mapToStruct(data); |
There was a problem hiding this comment.
_mapToStruct is undefined, which is causing errors. I think what you're looking for is data.toStruct().
Comment on lines
+758
to
+763
| test('getOrganizationMetadata', () async { | ||
| final expected = GetOrganizationMetadataResponse()..data = (Struct()..fields['key'] = (Value()..stringValue = 'value')); | ||
| when(serviceClient.getOrganizationMetadata(any)).thenAnswer((_) => MockResponseFuture.value(expected)); | ||
| final response = await appClient.getOrganizationMetadata('orgId'); | ||
| expect(response, equals(expected)); | ||
| }); |
There was a problem hiding this comment.
This test looks good, but we should probably add tests for all the other methods you implemented as well!
There was a problem hiding this comment.
Yes! Naveed and I were just debugging before I put all of the tests up - thanks for calling this out!
This was referenced Mar 18, 2025
njooma
approved these changes
Mar 18, 2025
JosephBorodach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add user-defined metadata CRUD operations
See ticket here