Merged
Conversation
v9 does not support ioredis
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the fetcher service to run on Node 24 by switching its Docker base image and restores ioredis support by downgrading connect-redis to version 8, with corresponding updates to the lockfile. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe Docker base image for apps/fetcher changed from node:lts-slim to node:current-slim. The package.json dependency for connect-redis was updated from ^9.0.0 to 8.x. No other instructions or configurations were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying flyxc with
|
| Latest commit: |
0e252f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9cafa49d.flyxc.pages.dev |
| Branch Preview URL: | https://vicb-misc-20250918.flyxc.pages.dev |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
apps/fetcher/Dockerfile(1 hunks)package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Sourcery review
- GitHub Check: Analyze (javascript)
- GitHub Check: build (22.x)
🔇 Additional comments (1)
package.json (1)
119-119: Pin connect-redis to a concrete range
- package.json (line 119) currently: "connect-redis": "8.x" — atypical and still floating; change to one of:
Option A (caret):Option B (exact; use the CI-validated version):- "connect-redis": "8.x", + "connect-redis": "^8.0.0",- "connect-redis": "8.x", + "connect-redis": "8.X.Y",- Repo search found no connect-redis/ioredis usages — verify which exact version your CI tests and confirm Redis store initialization (constructor signature and typings) remains compatible with ioredis.
| # Use the official lightweight Node.js image. | ||
| # https://hub.docker.com/_/node | ||
| FROM docker.io/node:lts-slim | ||
| FROM docker.io/node:current-slim |
There was a problem hiding this comment.
Pin Node to 24 for reproducible builds (avoid floating current).
Use a fixed base to match the PR goal “use Node 24” and prevent surprise major upgrades.
Apply:
-FROM docker.io/node:current-slim
+FROM docker.io/node:24-slimOptional hardening and image hygiene:
-RUN apt-get update -y \
- && apt-get install -y tini
+RUN apt-get update -y \
+ && apt-get install -y --no-install-recommends tini \
+ && rm -rf /var/lib/apt/lists/*Consider removing the non-deterministic global npm upgrade:
-RUN npm install -g npm@latest
+# Rely on image's npm (or pin a specific major if required)Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In apps/fetcher/Dockerfile around line 3, the base image is using the floating
tag "node:current-slim"; change it to a fixed Node 24 image (for example
"node:24-slim" or a specific digest) to ensure reproducible builds, remove or
avoid any global non-deterministic npm upgrade commands in the Dockerfile, and
optionally apply image-hardening best practices such as switching to a non-root
user, minimizing layers, and pinning package manager versions or using a digest
for the base image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Node 24 for the fecther
connect-redis v9 does not support ioredis any more
Summary by Sourcery
Upgrade the fetcher environment to Node 24 and revert connect-redis to v8 for ioredis support.
Enhancements:
Build:
Summary by CodeRabbit
No user-facing functionality changes are expected. These updates align the runtime environment and dependencies, improving consistency across services and ensuring stable builds without altering application behavior.