Skip to content

misc minor changes #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicb merged 2 commits into from
Sep 18, 2025
Merged

misc minor changes #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83f60b8
Use Node 24 for the fetcher
vicb Sep 18, 2025
0e252f2
Revert connect-redis to 8.x
vicb Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/fetcher/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use the official lightweight Node.js image.
# https://hub.docker.com/_/node
FROM docker.io/node:lts-slim
FROM docker.io/node:current-slim
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Pin Node to 24 for reproducible builds (avoid floating current).

Use a fixed base to match the PR goal “use Node 24” and prevent surprise major upgrades.

Apply:

-FROM docker.io/node:current-slim
+FROM docker.io/node:24-slim

Optional hardening and image hygiene:

-RUN apt-get update -y \
-	&& apt-get install -y tini
+RUN apt-get update -y \
+	&& apt-get install -y --no-install-recommends tini \
+	&& rm -rf /var/lib/apt/lists/*

Consider removing the non-deterministic global npm upgrade:

-RUN npm install -g npm@latest
+# Rely on image's npm (or pin a specific major if required)

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In apps/fetcher/Dockerfile around line 3, the base image is using the floating
tag "node:current-slim"; change it to a fixed Node 24 image (for example
"node:24-slim" or a specific digest) to ensure reproducible builds, remove or
avoid any global non-deterministic npm upgrade commands in the Dockerfile, and
optionally apply image-hardening best practices such as switching to a non-root
user, minimizing layers, and pinning package manager versions or using a digest
for the base image.


ENV NODE_ENV=production

Expand Down
93 changes: 5 additions & 88 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"axios": "1.7.9",
"commander": "^12.1.0",
"compression": "^1.7.5",
"connect-redis": "^9.0.0",
"connect-redis": "8.x",
"core-js": "^3.36.1",
"cors": "^2.8.5",
"d3-array": "^3.2.4",
Expand Down
Loading