Notifications: Only show "Silence" button for notification Toasts #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriadam
requested review from
DanielMcInnes,
ReinvdZee,
blammit and
ybott-qinetic
blammit
approved these changes
Nov 25, 2025
ybott-qinetic
requested changes
Nov 25, 2025
| radius: isSilenceButton ? Theme.geometry_button_radius : Theme.geometry_button_border_width | ||
|
|
||
| onClicked: { | ||
| if (isSilenceButton) { |
Contributor
There was a problem hiding this comment.
Why is this if statement condition redefined? The binding looks the same, but maybe I missing something.
Contributor
Author
There was a problem hiding this comment.
You're right, will undo this
| // unacknowledged notifications in the Notifications navbar icon bubble number. | ||
| ToastModel.removeAllInfoExcept(root.toastModelId) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
What this whitespace change intentional?
Contributor
Author
There was a problem hiding this comment.
yes, intentional, since we now have two separate if statements plus an unconditional
Non-notification toasts which are of type Warning or Error cannot be silenced as they cannot cause an alarm, since only notification backed toasts can cause alarms. This commit ensures that the "Silence" button will only be shown for notification-backed warning/error toasts, and that the normal "X" (dismiss/close) button is shown for non-notification-backed toasts. Contributes to issue #2675
chriadam
force-pushed
the
chriadam/toast-warning-dismiss
branch
from
c15cf9d to
e40ecc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-notification toasts which are of type Warning or Error cannot be silenced as they cannot cause an alarm, since only notification backed toasts can cause alarms.
This commit ensures that the "Silence" button will only be shown for notification-backed warning/error toasts, and that the normal "X" (dismiss/close) button is shown for non-notification-backed toasts.
Contributes to issue #2675