Skip to content

fix(skin): fix safari button alignment issue when zoomed#1495

Merged
sampotts merged 1 commit intomainfrom
fix/safari-button-zoom
Apr 30, 2026
Merged

fix(skin): fix safari button alignment issue when zoomed#1495
sampotts merged 1 commit intomainfrom
fix/safari-button-zoom

Conversation

@sampotts
Copy link
Copy Markdown
Collaborator

@sampotts sampotts commented Apr 30, 2026

Buttons in desktop Safari 26.4 were misaligned when zoomed in at ~200% or so. This is the fix.

Closes #1491


Note

Low Risk
Small CSS/Tailwind tweak limited to button layout (min-height: 0) in two skins; low chance of regressions outside of sizing/overflow behavior.

Overview
Fixes Safari desktop zoom alignment issues by explicitly setting min-height: 0 on the base .media-button styles.

Applies the same change in both the default and minimal skins, in both the raw CSS and Tailwind component definitions, to keep the two styling pipelines consistent.

Reviewed by Cursor Bugbot for commit 5042047. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Apr 30, 2026 6:35am

Request Review

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 5042047
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69f2f84949db1c0008218c3a
😎 Deploy Preview https://deploy-preview-1495--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sampotts sampotts requested review from decepulis and mihar-22 April 30, 2026 06:36
@github-actions
Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Size
/video (default) 28.83 kB
/video (default + hls) 162.13 kB
/video (minimal) 26.30 kB
/video (minimal + hls) 159.65 kB
/audio (default) 26.68 kB
/audio (minimal) 24.23 kB
/background 4.16 kB
Media (8)
Entry Size
/media/background-video 1.04 kB
/media/container 1.72 kB
/media/dash-video 236.58 kB
/media/hls-video 134.69 kB
/media/mux-audio 160.91 kB
/media/mux-video 160.85 kB
/media/native-hls-video 4.62 kB
/media/simple-hls-video 16.01 kB
Players (3)
Entry Size
/video/player 7.00 kB
/audio/player 5.12 kB
/background/player 3.86 kB
Skins (29)
Entry Type Size
/video/minimal-skin.css css 3.54 kB
/video/skin.css css 3.58 kB
/video/minimal-skin js 26.27 kB
/video/minimal-skin.tailwind js 26.48 kB
/video/skin js 28.81 kB
/video/skin.tailwind js 28.88 kB
/audio/minimal-skin.css css 2.56 kB
/audio/skin.css css 2.52 kB
/audio/minimal-skin js 24.23 kB
/audio/minimal-skin.tailwind js 24.39 kB
/audio/skin js 26.67 kB
/audio/skin.tailwind js 26.79 kB
/background/skin.css css 115 B
/background/skin js 1.15 kB
/live-video/minimal-skin.css css 3.54 kB
/live-video/skin.css css 3.58 kB
/live-video/minimal-skin js 26.06 kB
/live-video/minimal-skin.tailwind js 26.16 kB
/live-video/skin js 28.52 kB
/live-video/skin.tailwind js 28.56 kB
/live-audio/minimal-skin.css css 2.56 kB
/live-audio/skin.css css 2.52 kB
/live-audio/minimal-skin js 24.06 kB
/live-audio/minimal-skin.tailwind js 24.03 kB
/live-audio/skin js 26.42 kB
/live-audio/skin.tailwind js 26.46 kB
/base.css css 162 B
/shared.css css 88 B
/skin-element js 1.35 kB
UI Components (25)
Entry Size
/ui/alert-dialog 989 B
/ui/alert-dialog-close 465 B
/ui/alert-dialog-description 451 B
/ui/alert-dialog-title 369 B
/ui/buffering-indicator 2.49 kB
/ui/captions-button 2.59 kB
/ui/cast-button 2.62 kB
/ui/compounds 4.15 kB
/ui/controls 2.03 kB
/ui/error-dialog 3.10 kB
/ui/fullscreen-button 2.58 kB
/ui/hotkey 1.91 kB
/ui/mute-button 2.58 kB
/ui/pip-button 2.55 kB
/ui/play-button 2.56 kB
/ui/playback-rate-button 2.67 kB
/ui/popover 1.82 kB
/ui/poster 1.88 kB
/ui/seek-button 2.59 kB
/ui/slider 1.51 kB
/ui/thumbnail 2.96 kB
/ui/time 2.52 kB
/ui/time-slider 3.92 kB
/ui/tooltip 2.03 kB
/ui/volume-slider 2.66 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react — no changes
Presets (7)
Entry Size
/video (default) 23.53 kB
/video (default + hls) 155.68 kB
/video (minimal) 21.14 kB
/video (minimal + hls) 153.27 kB
/audio (default) 19.10 kB
/audio (minimal) 17.62 kB
/background 756 B
Media (7)
Entry Size
/media/background-video 575 B
/media/dash-video 235.21 kB
/media/hls-video 133.34 kB
/media/mux-audio 159.31 kB
/media/mux-video 159.49 kB
/media/native-hls-video 3.13 kB
/media/simple-hls-video 14.55 kB
Skins (26)
Entry Type Size
/video/minimal-skin.css css 3.49 kB
/video/skin.css css 3.50 kB
/video/minimal-skin js 21.05 kB
/video/minimal-skin.tailwind js 24.59 kB
/video/skin js 23.46 kB
/video/skin.tailwind js 24.69 kB
/audio/minimal-skin.css css 2.45 kB
/audio/skin.css css 2.40 kB
/audio/minimal-skin js 17.57 kB
/audio/minimal-skin.tailwind js 20.07 kB
/audio/skin js 19.03 kB
/audio/skin.tailwind js 20.07 kB
/background/skin.css css 90 B
/background/skin js 272 B
/live-video/minimal-skin.css css 3.49 kB
/live-video/skin.css css 3.50 kB
/live-video/minimal-skin js 17.79 kB
/live-video/minimal-skin.tailwind js 21.18 kB
/live-video/skin js 20.18 kB
/live-video/skin.tailwind js 21.32 kB
/live-audio/minimal-skin.css css 2.45 kB
/live-audio/skin.css css 2.40 kB
/live-audio/minimal-skin js 15.79 kB
/live-audio/minimal-skin.tailwind js 18.06 kB
/live-audio/skin js 17.26 kB
/live-audio/skin.tailwind js 18.19 kB
UI Components (20)
Entry Size
/ui/alert-dialog 1.11 kB
/ui/buffering-indicator 1.85 kB
/ui/captions-button 2.03 kB
/ui/cast-button 2.04 kB
/ui/controls 1.89 kB
/ui/error-dialog 2.31 kB
/ui/fullscreen-button 2.03 kB
/ui/mute-button 2.05 kB
/ui/pip-button 2.03 kB
/ui/play-button 2.00 kB
/ui/playback-rate-button 2.02 kB
/ui/popover 1.87 kB
/ui/poster 1.74 kB
/ui/seek-button 2.10 kB
/ui/slider 3.33 kB
/ui/thumbnail 2.08 kB
/ui/time 2.54 kB
/ui/time-slider 3.00 kB
/ui/tooltip 2.17 kB
/ui/volume-slider 2.39 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core — no changes
Entries (9)
Entry Size
. 4.96 kB
/dom 11.93 kB
/dom/media/custom-media-element 1.90 kB
/dom/media/dash 234.36 kB
/dom/media/google-cast 4.07 kB
/dom/media/hls 132.72 kB
/dom/media/mux 158.81 kB
/dom/media/native-hls 2.52 kB
/dom/media/simple-hls 13.89 kB
🏷️ @videojs/element — no changes
Entries (2)
Entry Size
. 996 B
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Size
. 1.39 kB
/html 695 B
/react 360 B
🔧 @videojs/utils — no changes
Entries (10)
Entry Size
/array 104 B
/dom 1.92 kB
/events 319 B
/function 327 B
/object 275 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B
📦 @videojs/spf — no changes
Entries (3)
Entry Size
. 4.29 kB
/dom 13.40 kB
/playback-engine 13.26 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

@sampotts sampotts merged commit c5b06cf into main Apr 30, 2026
26 checks passed
@sampotts sampotts deleted the fix/safari-button-zoom branch April 30, 2026 21:03
@luwes luwes mentioned this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: CSS aspect-ratio Breaks Button Sizing When Zoomed in Desktop Safari

2 participants