Skip to content

fix(skin): fix safari button alignment issue when zoomed #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampotts merged 1 commit into from
Apr 30, 2026
Merged

fix(skin): fix safari button alignment issue when zoomed #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/skins/src/default/css/components/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
flex-shrink: 0;
align-items: center;
justify-content: center;
min-height: 0;
padding: 0.5rem 1rem;
text-align: center;
touch-action: manipulation;
Expand Down
2 changes: 1 addition & 1 deletion packages/skins/src/default/tailwind/components/button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { cn } from '@videojs/utils/style';

export const button = {
base: cn(
'flex items-center justify-center shrink-0 border-none cursor-pointer select-none text-center touch-manipulation',
'flex items-center justify-center shrink-0 border-none cursor-pointer select-none text-center touch-manipulation min-h-0',
'py-2 px-4 rounded-full',
'outline-2 outline-transparent -outline-offset-2',
'transition-[background-color,outline-offset,scale] will-change-[scale] duration-150 ease-out',
Expand Down
1 change: 1 addition & 0 deletions packages/skins/src/minimal/css/components/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
flex-shrink: 0;
align-items: center;
justify-content: center;
min-height: 0;
padding: 0.5rem 1rem;
text-align: center;
touch-action: manipulation;
Expand Down
2 changes: 1 addition & 1 deletion packages/skins/src/minimal/tailwind/components/button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { cn } from '@videojs/utils/style';

export const button = {
base: cn(
'flex items-center justify-center shrink-0 border-none cursor-pointer select-none text-center touch-manipulation',
'flex items-center justify-center shrink-0 border-none cursor-pointer select-none text-center touch-manipulation min-h-0',
'py-2 px-4 rounded-lg',
'outline-2 outline-transparent -outline-offset-2',
'transition-[background-color,outline-offset,scale] will-change-[scale] duration-150 ease-out',
Expand Down
Loading