[#15] Mock asset foundation: TDD plan + Assets service scaffold#24
Draft
joshuapease wants to merge 3 commits into
Draft
[#15] Mock asset foundation: TDD plan + Assets service scaffold#24joshuapease wants to merge 3 commits into
joshuapease wants to merge 3 commits into
Conversation
- Restructure 4 phases into 12 test-first implementation units (U1–U12) - Add Testing Strategy: unit/functional split, harness affordances, manual-only items - Map every AC/NFR to a concrete Codeception test file - Reframe Phase 1 as greenfield scaffolding (feature is unscaffolded; no WIP to fix) - Note ext-imagick already present in CI; quality gates swapped to automated
- Register `assets` component with getAssets() getter + @property-read - Add make() seam returning a MockAssetBuilder stub (fleshed out in U3/U5) - Establish convention: each component gets a typed getter + @property-read - Cover wiring with PluginWiringTest and AssetsTest (test-first)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR in the Mock Asset feature series (#15). This is the standalone
foundation the plan designates to land before feature work, plus the TDD
rework of the plan itself.
What's here
Plan rework (
docs/plans/2026-05-25-feat-mock-asset-service-plan.md)the few manual-only items: Imager X Pro AC8, Imagick-absent NFR4)
entirely unscaffolded (no WIP
MockAssetto "fix" as the original implied)ext-imagickis already in CI'sPHP_EXTENSIONS, so generation testsneed no workflow change
U1 — Assets service + plugin wiring
assetscomponent with a typedgetAssets()getter and@property-read, establishing the convention that every component gets bothmake()seam returning aMockAssetBuilder(a minimal stub here;fluent setters /
configure()/ defaults arrive in U3, config applicationand URL signing in U5)
Testing
ddev test unit— 13 tests, 34 assertions pass (4 new wiring/seam tests,written test-first; 9 pre-existing, no regressions)
ddev phpstan— clean (level 4)ddev composer check-cs— clean (ECS)Scope notes
Imager X) land in stacked follow-up PRs.
MockAssetBuilderis intentionally an empty stub at this stage.