-
Notifications
You must be signed in to change notification settings - Fork 31
chore: bump to deck 9.1 #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
957466c
e63204f
03a2f0f
8c419bf
02ffe2f
0e6eeae
621f594
465f103
fcfd2d9
cf8a4ea
9e69a10
5e8d373
290b99c
485e7db
fdb6e24
256fe24
a6f0a4c
fce220c
d2ea066
69c4da2
93f7f59
6334935
4967fc8
5e79461
5bbf88a
093ab76
b7ce53a
b011b98
c4e99fe
52af878
57d31c3
cc61f96
547d5e8
b299616
20d76c7
b6ac51f
00272be
9807328
3204ff6
46b66a5
57fc004
dcd38a2
7bbed20
1a069de
c339bf9
0f61f3d
fa014a0
46193b3
877c8da
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ coverage/ | |
| .cache/ | ||
|
|
||
| tsconfig.tsbuildinfo | ||
| tsconfig.build.tsbuildinfo | ||
|
|
||
| */**/yarn.lock | ||
| !website/yarn.lock | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,10 @@ | |
| /* global window */ | ||
|
|
||
| import React, {Component, RefObject} from 'react'; | ||
| import DeckGL, {DeckGLRef} from '@deck.gl/react/typed'; | ||
| import DeckGL, {DeckGLRef} from '@deck.gl/react'; | ||
| import {MapRef, StaticMap, StaticMapProps} from 'react-map-gl'; | ||
| import {MapboxLayer} from '@deck.gl/mapbox/typed'; | ||
| import type {DeckProps, MapViewState} from '@deck.gl/core/typed'; | ||
| import {MapboxOverlay as MapboxLayer} from '@deck.gl/mapbox'; | ||
|
||
| import type {DeckProps, MapViewState} from '@deck.gl/core'; | ||
| import isEqual from 'lodash.isequal'; | ||
|
|
||
| import {deckStyle, DeckCanvas} from './styled-components'; | ||
|
|
@@ -163,13 +163,13 @@ export class ExportVideoPanelPreview extends Component< | |
|
|
||
| // If there aren't any layers, combine map and deck with a fake layer. | ||
| if (!keplerLayers.length) { | ||
| map.addLayer(new MapboxLayer({id: '%%blank-layer', deck})); | ||
| map.addLayer(new MapboxLayer({id: '%%blank-layer', ...deck})); | ||
| mapboxLayerIds.push('%%blank-layer'); | ||
| } | ||
|
|
||
| for (let i = 0; i < keplerLayers.length; i++) { | ||
| // Adds DeckGL layers to Mapbox so Mapbox can be the bottom layer. Removing this clips DeckGL layers | ||
| map.addLayer(new MapboxLayer({id: keplerLayers[i].id, deck}), beforeId); | ||
| map.addLayer(new MapboxLayer({id: keplerLayers[i].id, ...deck}), beforeId); | ||
| mapboxLayerIds.push(keplerLayers[i].id); | ||
| } | ||
|
|
||
|
|
@@ -207,7 +207,7 @@ export class ExportVideoPanelPreview extends Component< | |
| controller={true} | ||
| glOptions={{stencil: true}} | ||
| onWebGLInitialized={gl => this.setState({glContext: gl})} | ||
| onViewStateChange={({viewState: vs}) => setViewState(vs as MapViewState)} | ||
| onViewStateChange={({viewState: vs}) => setViewState(vs)} | ||
| {...(disableStaticMap ? {onAfterRender: this._onAfterRender} : {})} | ||
| width={resolution[0]} | ||
| height={resolution[1]} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to use the version of loaders on master since there's an issue with GIF encoding the videos module in later versions, and we're not using anything from the newer version of loaders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^3.4.13?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to bump to deck9.1, I need
@loaders.gl/core@"^4.2.0", where is the encoding issue discussed?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visgl/loaders.gl#2164
A fix was attempted, but it's still an issue. I have a reproduction in #305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually still affects this branch too after removing the resolution