chore: bump to deck 9.1 #285

charlieforward9 · 2025-01-19T04:14:21Z

Tried bumping the most important (primarily those within the visgl org) dependencies up to their latest versions and fixing the build issues that came along with them.

Closes #277
Closes #283
For #309

chrisgervang

Thank you! This is a great start. I think we'll want to switch to using the MapboxOverlay since MapboxLayer has been deprecated, but it still works as-is we can do that in a follow up PR.

tsconfig.build.tsbuildinfo

package-lock.json

chrisgervang · 2025-01-19T18:28:35Z

modules/react/src/components/export-video/export-video-panel-preview.tsx

 import {MapRef, StaticMap, StaticMapProps} from 'react-map-gl';
-import {MapboxLayer} from '@deck.gl/mapbox/typed';
-import type {DeckProps, MapViewState} from '@deck.gl/core/typed';
+import {MapboxOverlay as MapboxLayer} from '@deck.gl/mapbox';


Oh, this actually isn't a drop-in replacement and will require some changes to work. http://deck.gl/docs/upgrade-guide#deckglmapbox

As a temporary fix I believe we can still import MapboxLayer with import MapboxLayer from '@deck.gl/mapbox/mapbox-layer'

Rather get this out of the way now. Im not getting any type errors, and all instances in the src/ folder implement the same props {id: ..., ...deck} where id is a string and deck is a Deck obj that may have also been changed in v9 to reflect the change. Let me know.

The API is different in MapboxOverlay. It creates a deck instance rather than getting passed an instance and that inversion would require a bit of refactoring

@chrisgervang

I replaced the deck instance with the deck props in 03a2f0f

I see that the link shows that MapboxLayer to MapboxOverlay shows interleaved: true as the replacement. Should the updated API include this?

charlieforward9 · 2025-01-19T21:15:53Z

Would this also close #251 and #277?

modules/core/package.json

chrisgervang · 2025-01-21T18:06:53Z

modules/react/src/components/export-video/export-video-panel-preview.tsx

 import {MapRef, StaticMap, StaticMapProps} from 'react-map-gl';
-import {MapboxLayer} from '@deck.gl/mapbox/typed';
-import type {DeckProps, MapViewState} from '@deck.gl/core/typed';
+import {MapboxOverlay as MapboxLayer} from '@deck.gl/mapbox';


The API is different in MapboxOverlay. It creates a deck instance rather than getting passed an instance and that inversion would require a bit of refactoring

chrisgervang · 2025-01-21T18:08:56Z

Would this also close #251 and #277?

#251, maybe. #277, not yet since it would require the addition of a MapView with a white clearColor in the PR, I imagine.

chrisgervang · 2025-01-21T19:13:57Z

Not all users (e.g. Kepler.gl) are able to upgrade to deck v9 yet, so I'm considering a hubble 1.4 release with support for the latest version of deck v8 and bumping Hubble.gl to 2.0 for deck v9 support.

charlieforward9 · 2025-01-22T06:05:46Z

2.0 for deck v9 support

My dependent repo uses deck v9, so I'll aim this PR for 2.0. I am happy to do dig into the MapboxOverlay refactor in the coming days to get that out of the way as well. (Although it strangely does not throw any lint errors when passing deck in as of now)

charlieforward9 · 2025-01-23T20:41:31Z

@chrisgervang can we get a 2.0-alpha version released from this PR? Not entirely sure how that'd happen given its monorepo configuration? I'd like to start testing with my dependent application without having to wait for this to land, especially if youre trying to ship a 1.4 version first.

Thank you.

charlieforward9 · 2025-01-31T05:31:30Z

@chrisgervang what your roadmap for this PR looking like?

I've been waiting to see this land before getting back to the side project I've been looking to enhance with this.

Anything I can help with?

chrisgervang · 2025-01-31T06:08:41Z

I'm actively updating all of the examples to use MapboxOverlay.

Then I'll be going through the release process of 1.4, which includes updating dependencies in the existing website and publishing a beta (and assuming all is good, immediately graduating to production).

Then we can upgrade to deck 9 with this PR, and I think it could make sense to bump to 2.0 at that point.

At some point soon I'd like to upgrade the website to use the latest vis.gl docusorus template instead of gatsby since it's a lot less painful to maintain. This can happen in parallel to the releases.

chrisgervang · 2025-01-31T06:46:57Z

Hey @charlieforward9 you can merge master in, I don't think they'll be many other changes

charlieforward9 · 2025-01-31T13:47:17Z

@chrisgervang Ok, I'll follow your lead. Just keep me in touch and I'll help out.

When you said I can merge master in, what do you mean? I do not have merge access.

chrisgervang · 2025-01-31T16:02:31Z

Oh I just meant I've pushed changes to master that you'll need to merge into your branch here

modules/core/src/adapters/deck-adapter.ts

modules/react/src/components/export-video/export-video-panel-preview.tsx

chrisgervang · 2025-02-07T05:52:19Z

Just released 1.4! If you have time, I would appreciate it if you could merge in the latest changes and test the examples in the website

yarn bootstrap
cd website && yarn
yarn start

Then navigate to the examples in the site and try rendering different formats.
Then let's try a website static build.. yarn build then yarn serve

I think getting 9.0 in the examples, and keeping some kind of compatibility with kepler.gl (which is on deck 8.9) are the high priority issues to release 2.0. I'm hoping to include #305, #300, and #231 in 2.0 but we don't need to consider them blockers.

charlieforward9 · 2025-02-08T15:58:04Z

@chrisgervang thanks! Looking forward to it.

Just an fyi, I tried an example in the website last night, specifically the Kepler one, and tried exporting some of the sample datasets as GIF, and it would not download, eventually crashing the page.

Not sure if I'm doing something wrong here as I'm not too experienced with Kepler, but I wanted to point that out as I dove into this.

chrisgervang · 2025-02-08T19:41:24Z

Good to know - kepler is the most complicated example, maybe try the simplest quick start one and move up to the trips one

tsconfig.module.json

modules/react/package.json

chrisgervang · 2025-02-08T20:13:42Z

modules/core/package.json

    "build-bundle": "ocular-bundle ./bundle.ts"
  },
  "dependencies": {
-    "@loaders.gl/core": "^3.0.0",


I'd prefer to use the version of loaders on master since there's an issue with GIF encoding the videos module in later versions, and we're not using anything from the newer version of loaders

^3.4.13 ?

In order to bump to deck9.1, I need @loaders.gl/core@"^4.2.0", where is the encoding issue discussed?

visgl/loaders.gl#2164

A fix was attempted, but it's still an issue. I have a reproduction in #305

It actually still affects this branch too after removing the resolution

charlieforward9 · 2025-02-08T22:10:25Z

if you could merge in the latest changes

@chrisgervang Im seeing master and 1.4-release, which one should I be pulling from? I could wait till they merge to resolve conflicts once.

Then let's try a website static build.. yarn build then yarn serve

I am unable to run yarn build without resolving these comments, can you provide guidance?

Found in visgl/hubble.gl#285 (comment)

chrisgervang

This is close! I'm making a series of updates to prepare it for merge, and will split the features, tar/zip commits into their own PR.

For features, I may instead only go with #310, which internalizes the features prop rather than fully remove it. It does the same thing as your version but with a simpler type.

docs/README.md

docs/api-reference/keyframe/deck-layer-keyframes.md

examples/website/trips/package.json

lerna.json

modules/main/package.json

modules/react/src/components/render-player.tsx

charlieforward9 · 2025-03-17T17:54:30Z

Ok, great to hear.

@chrisgervang

Let me know if there's anything I can help with. I am eagerly waiting to implement this and advance it's capabilities with the new release.

package.json

This reverts commit 46b66a5.

coveralls · 2025-03-20T19:23:18Z

Pull Request Test Coverage Report for Build 13978428409

Details

25 of 53 (47.17%) changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 49.415%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/react/src/components/quick-animation.tsx	5	6	83.33%
modules/react/src/components/export-video/export-video-panel-preview.tsx	7	10	70.0%
modules/core/src/adapters/deck-adapter.ts	1	5	20.0%
modules/core/src/capture/video-capture.ts	0	20	0.0%

Totals
Change from base Build 13962009025:	-0.04%
Covered Lines:	2449
Relevant Lines:	5014

💛 - Coveralls

chrisgervang · 2025-03-20T19:31:55Z

@charlieforward9 I got ci tests working again, and the maplibre-based website examples all work 100%.

The remaining issue is background color on the camera and quick-start examples is not setting. We can merge this PR in and cut an alpha with this bug unresolved.

The backround is supposed to be a purple color matching the polygon stroke color.

chrisgervang · 2025-03-20T19:37:10Z

examples/website/camera/app.jsx

+            new MapView({
+              farZMultiplier: 3,
+              clear: {
+                color: [61 / 255, 20 / 255, 76 / 255, 1]
+              }
+            })


This doesn't seem to be working yet

Yeah Ive struggled to get that working, but as I integrate it into my codebase, Ill have much more time to learn and explore its internals.

Let me know when the release goes live. Thanks!

chrisgervang · 2025-03-21T00:59:06Z

@charlieforward9 just released 2.0.0-alpha.3

chore: bump deps

957466c

chrisgervang approved these changes Jan 19, 2025

View reviewed changes

tsconfig.build.tsbuildinfo Outdated Show resolved Hide resolved

package-lock.json Outdated Show resolved Hide resolved

chrisgervang reviewed Jan 19, 2025

View reviewed changes

chore: bump deps

e63204f

chrisgervang reviewed Jan 21, 2025

View reviewed changes

refactor: replace deck instance with props in MapboxOverlay

03a2f0f

chrisgervang and others added 7 commits February 3, 2025 14:06

New Website

8c419bf

links

02ffe2f

Delete README.md

0e6eeae

fix kepler

621f594

website action

465f103

pull latest changes in and bump

fcfd2d9

pull latest changes in and bump

cf8a4ea

charlieforward9 commented Feb 4, 2025

View reviewed changes

modules/core/src/adapters/deck-adapter.ts Outdated Show resolved Hide resolved

modules/react/src/components/export-video/export-video-panel-preview.tsx Show resolved Hide resolved

chrisgervang changed the title ~~chore: bump deps~~ chore: bump to deck 9.1 Feb 8, 2025

chrisgervang reviewed Feb 8, 2025

View reviewed changes

ibgreen pushed a commit to visgl/luma.gl that referenced this pull request Mar 15, 2025

fix: add WebGLContextProps.stencil

d2497ac

Found in visgl/hubble.gl#285 (comment)

ibgreen mentioned this pull request Mar 15, 2025

fix: add WebGLContextProps.stencil visgl/luma.gl#2352

Merged

chrisgervang reviewed Mar 17, 2025

View reviewed changes

Apply suggestions from code review

547d5e8

chrisgervang mentioned this pull request Mar 19, 2025

refactor(encoders): remove archive format, standardize zip #314

Merged

chrisgervang added 3 commits March 19, 2025 21:32

Merge branch 'master' into pr/285

b299616

Merge branch 'master' into pr/285

20d76c7

Disable node tests

b6ac51f

chrisgervang mentioned this pull request Mar 20, 2025

2.0 Tracker #309

Open

8 tasks

chrisgervang added 3 commits March 20, 2025 10:14

Enable headless browser tests

00272be

Use deck 9.1 in scripting

9807328

audit html

3204ff6

chrisgervang reviewed Mar 20, 2025

View reviewed changes

package.json Show resolved Hide resolved

chrisgervang and others added 7 commits March 20, 2025 10:27

Remove packageManager

46b66a5

Fix website build

57fc004

Revert "Remove packageManager"

dcd38a2

This reverts commit 46b66a5.

add packageManager to website

7bbed20

define clear color in views for each example

1a069de

use browser tests in CI instead of node tests

c339bf9

hack around dev-tools running node tests in CI

0f61f3d

chrisgervang added 2 commits March 20, 2025 12:35

restore lint in ci

fa014a0

TODO

46193b3

chrisgervang reviewed Mar 20, 2025

View reviewed changes

old docs

877c8da

chrisgervang approved these changes Mar 20, 2025

View reviewed changes

chrisgervang merged commit f653adb into visgl:master Mar 20, 2025
1 check passed

chore: bump to deck 9.1 #285

chore: bump to deck 9.1 #285

Uh oh!

Conversation

charlieforward9 commented Jan 19, 2025 • edited by chrisgervang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisgervang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charlieforward9 Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charlieforward9 commented Jan 19, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisgervang commented Jan 21, 2025

Uh oh!

chrisgervang commented Jan 21, 2025

Uh oh!

charlieforward9 commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charlieforward9 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charlieforward9 commented Jan 31, 2025

Uh oh!

chrisgervang commented Jan 31, 2025

Uh oh!

chrisgervang commented Jan 31, 2025

Uh oh!

charlieforward9 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisgervang commented Jan 31, 2025

Uh oh!

Uh oh!

Uh oh!

chrisgervang commented Feb 7, 2025

Uh oh!

charlieforward9 commented Feb 8, 2025

Uh oh!

chrisgervang commented Feb 8, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisgervang Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charlieforward9 commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisgervang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

charlieforward9 commented Jan 19, 2025 •

edited by chrisgervang

Loading

charlieforward9 Jan 19, 2025 •

edited

Loading

charlieforward9 commented Jan 22, 2025 •

edited

Loading

charlieforward9 commented Jan 23, 2025 •

edited

Loading

charlieforward9 commented Jan 31, 2025 •

edited

Loading

chrisgervang Feb 10, 2025 •

edited

Loading

charlieforward9 commented Feb 8, 2025 •

edited

Loading

coveralls commented Mar 20, 2025 •

edited

Loading