-
Notifications
You must be signed in to change notification settings - Fork 31
refactor(encoders): remove archive format, standardize zip #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the encoder modules to remove the legacy 'archive' configuration and standardize ZIP as the only supported archive format, updating both code and documentation.
- Removed the archive option from PNG and JPEG encoders.
- Updated examples and documentation to reflect ZIP encryption.
- Deleted TAR-related utility and builder files.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/core/src/encoders/frame-encoder.ts | Removed archive configuration from PNG and JPEG format settings. |
| examples/website/basic-basemap/app.jsx | Removed archive property from formatConfigs and simplified component structure. |
| examples/website/basic-basemap-mapbox-legacy/app.jsx | Removed archive property and adjusted formatting in usage of DeckGLOverlay. |
| examples/website/basic-basemap-mapbox/app.jsx | Removed archive property and adjusted formatting in usage of DeckGLOverlay. |
| modules/react/src/components/quick-animation.tsx | Updated formatConfigs to remove the archive field in PNG settings. |
| examples/website/camera/app.jsx | Removed archive from PNG settings and updated JPEG configuration in formatConfigs. |
| modules/react/src/components/export-video/export-video-panel-container.tsx | Removed archive property from PNG and JPEG format configurations. |
| docs/api-reference/encoder/jpeg-sequence-encoder.md | Updated encoder description and configuration to reflect ZIP usage instead of TAR. |
| examples/website/terrain/app.jsx | Removed archive property from PNG settings. |
| examples/website/trips/app.tsx | Removed archive property from PNG settings. |
| docs/api-reference/encoder/png-sequence-encoder.md | Updated encoder description and configuration to reflect ZIP usage instead of TAR. |
| modules/core/src/encoders/video/jpeg-sequence-encoder.ts | Removed TAR support; standardized JPEG sequence encoding to use ZIP exclusively. |
| modules/core/src/encoders/video/png-sequence-encoder.ts | Removed TAR support; standardized PNG sequence encoding to use ZIP exclusively. |
| modules/core/src/encoders/tar/* | Deleted unused TAR-related modules (header, tar-builder, tar, utils). |
Comments suppressed due to low confidence (1)
modules/core/src/encoders/video/jpeg-sequence-encoder.ts:24
- [nitpick] Consider standardizing the access of ZipWriter.extensions across encoders. Since PNGSequenceEncoder does not use optional chaining, removing it here could improve consistency.
this.extension = `.${ZipWriter.extensions?.[0]}`;
Pull Request Test Coverage Report for Build 13961936087Details
💛 - Coveralls |
|
Tested website examples 👍 |
For #309
Split out from #285