Mini Chart Padding (+Line chart improvements?) #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-prop is passed all the way to useLineState in order to control the layout.
This resolves the padding inconsistency on all line charts so the mini-prop is no longer needed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 3, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the mini chart padding and aligns it with the original design in the first commit.
The second commit applies this behavior (inset of labels) more broadly in order to also fix the padding on the details page. While this fixes the padding, it makes the existing problems with the label misalignments and general spacing much more prominent so these topics should be further addressed before merging. (problems are documented in #348 )
Additionally, the small bug described in #370 also hasn't been
Related Issues
fixes #361
relate but not adressed:
Testing Performed
Testing/Reproduction Steps
Screenshots
Checklist
Notes for Reviewers
Since we do not show this panel for the september release, we can have a look at this when we prepare for the sunshine testing phase.
We should either address the issues related to the mini- and line charts mentioned above in this PR or drop the second commit.