Skip to content

Conversation

ptbrowne
Copy link
Contributor

@ptbrowne ptbrowne commented Sep 25, 2025

Description

Testing layout options to have less "header" height.

(1) Integrate the detail page title inside the content
(2) Remove the "back to map view' button as we already have the link in the menu bar
(3) Added some navigation links to the Details menu (especially relevant for canton / municipality where this all area is empty since there is not sunshine)
(4) Add a "Detail" item in the top horizontal menu when we are in detail page

Links

Inspiration

Both do not have a tall header
https://www.trockenheit.admin.ch/en
https://www.meteoswiss.admin.ch/#tab=forecast-map

Comments

I am not super happy with (3) as it looks too long, perhaps the sublinks could only be active while the page containing them is opened

Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elcom-electricity-price-website Ready Ready Preview Comment Sep 25, 2025 1:11pm

Copy link

argos-ci bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 22 changed Sep 25, 2025, 1:18 PM

@noahonyejese
Copy link
Contributor

Hi @ptbrowne I think most of the changes are pretty good however the only thing I would do is revert back is the sidebar. And implement this Design by Annina https://www.figma.com/design/opxTrkS7ygOwWw6iGbHL1O/ElCom---Sunshine-Visual-Design?node-id=5422-32063&t=gIHCKJWUyCHhXeNM-4
I thought this was a pretty good proposal

Let me know what you think?

@mevionfamos
Copy link
Contributor

mevionfamos commented Sep 25, 2025

Thanks @ptbrowne I like the more compact version. It also works well on mobile

(1) Integrate the detail page title inside the content -> good idea, makes sense
(2) Remove the "back to map view' button as we already have the link in the menu bar -> I personally miss the "back to map" button but I see how it is a bit redundant. would it make sense to put it in the sidebar? But we can also leave it, I don't think people will complain.
image
(3) Added some navigation links to the Details menu (especially relevant for canton / municipality where this all area is empty since there is not sunshine) -> better than what we currently have, but agree with @noahonyejese , ideally we would use the same logic like for sunshine, as per Annina's design proposal (however, I'm not sure if we also have a mobile layout for this, can fit all the tabs on small screens?) see #218
(4) Add a "Detail" item in the top horizontal menu when we are in detail page -> great idea, we should definitely keep this

@mevionfamos mevionfamos mentioned this pull request Sep 25, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants