-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add setSource method #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setSource method #153
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0009f56 to
09fe160
Compare
|
In my test, I have the videoReference ( videoReference.src = 'new-src.mp4' // prefer src method over videoReference.setAttribute('src', 'new-src.mp4'); both trigger the DOM but src method also triggers a reload of the video content
videoReference.load() // force video reloadThe issue is that the player doesn't reload time (current time and time duration) and current progress bar. 2025-02-19.012843.mp4There is any method of player that I should call? |
|
Have you tested with audio and video HTML5? |
Yes, the change works also with audio: the source is updated but the player doesn't reload time (current time and time duration) and current progress bar: 2025-02-22.233921.mp4 |
The action to be taken after loading the new media is not so simple. The player needs to be “reset”
|
|
The reset logic of the player should be added as event every time the source is changed by |
Yes. We can dispatch a new event But this is only for user-specific purposes. The whole process of updating the player after changing the source should be dealt with here. |
|
@yoriiis is attempting to deploy a commit to the Vlitejs Team on Vercel. A member of the Team first needs to authorize it. |
b43456a to
e3cf46e
Compare
|
The status checks are not updating, workflow have changed. Development has been moved to another PR (#186); I am copying you in. |
Fix #151
This PR contains a:
Note
To be tested and reviewed