-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add set source #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add set source #186
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
14f493d to
f90345f
Compare
| | `getDuration()` | - | `Promise` | Get the duration | | ||
| | `mute()` | - | - | Mute the volume | | ||
| | `unMute()` | - | - | Unmute the volume | | ||
| | `setSource(source)` | `String` | - | Set the new media source | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add parameter value info
| | `getDuration()` | - | `Promise` | Get the duration | | ||
| | `mute()` | - | - | Mute the volume | | ||
| | `unMute()` | - | - | Unmute the volume | | ||
| | `setSource(source)` | `String` | - | Set the new media source | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add note about to play trigger by this method
|
@yoriiis Thanks, what about to call the |
f90345f to
626b760
Compare
It's a new method, so I don't really see how it limits migration. In my opinion, |
|
@rtritto Could you test this feature? Since you were the one who requested it. |
Having different method names the migration from video.js to vLite is: - videoRef.src(newSrc)
+ videoRef.setSource(newSrc)It's not a limit, but if both methods have same name, you have 1 less reference to migrate. Another advantage is that
What do you think about, in another PR, the logic of all methods of the getter/setter can be improved.
Yes |
|
@yoriiis I can't test, I got cross-origin ~ header CORS “Access-Control-Allow-Origin” ~ 301 on "https://yoriiis.github.io/cdn/static/vlitejs/demo-video-html5.mp4". |
|
@rtritto I'm happy you planned to migrate from Video.js to vLitejs! I understand your point about migration, but I prefer to stick to my own terminology, which I find clearer. And, the goal of this library is not to be identical to video.js |
You can access the Vercel preview URL? The error appears when you submit a new source? If you have the project in local perhaps? I will check the error soon |
Initial PR #153
cc/ @rtritto