Fix the AMD template input reference in the README - #496
Open
Hoiyeuhng wants to merge 1 commit into
Open
Conversation
`buildkite/bootstrap-amd.sh` renders `test-template-amd.j2` against `.buildkite/test-amd.yaml`, not `.buildkite/test-pipeline.yaml`. Both files exist on vLLM `main`, so the stale link resolves and the error is easy to miss. Signed-off-by: Haiyang Luo <41023868+Hoiyeuhng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.buildkite/test-amd.yaml, the filebootstrap-amd.shactually rendersWhy
buildkite/bootstrap-amd.shinvokes:but the README says the template renders vLLM's
test-pipeline.yaml. Both files exist on vLLMmain, so the stale link resolves instead of 404ing, which is why the error has gone unnoticed.Validation
buildkite/bootstrap-amd.sh:170confirms the rendered input istest-amd.yaml.buildkite/test-amd.yamlexists onvllm-project/vllm@mainpre-commit run --files README.md— all applicable hooks passAI assistance
AI assistance was used to locate and prepare this change. The submitter has reviewed every changed line.