Format support matrix statuses natively in buildkite shell scripts#1877
Open
Format support matrix statuses natively in buildkite shell scripts#1877
Conversation
RobMulla
requested review from
QiliangCui,
jcyang43 and
vipannalla
as code owners
RobMulla
force-pushed
the
fix-upstream-csv-formatting
branch
from
1ffda63 to
93b6279
Compare
RobMulla
added
ready
RobMulla
force-pushed
the
fix-upstream-csv-formatting
branch
from
93b6279 to
636ed7c
Compare
jcyang43
reviewed
Mar 6, 2026
| @@ -0,0 +1,131 @@ | |||
| #!/bin/bash | |||
Collaborator
There was a problem hiding this comment.
Hi @RobMulla, is this test actually passing for you btw?
Collaborator
Author
There was a problem hiding this comment.
I think this is because you are running on mac - newer bash syntax crashes on Mac's native bash. I updated generate_support_matrices so it should work now.
Collaborator
There was a problem hiding this comment.
I initially suspected it was a mac issue but tested on linux & got the same error XD
But the test is passing with your new changes now, thanks.
- record_step_result.sh now directly applies UI-facing statuses like '✅ Passing' - generate_support_matrices.sh now surfaces these formatted statuses - microbenchmark pivoting logic cleaned up to use simple shortened headers Signed-off-by: Rob Mulla <rob.mulla@gmail.com>
Signed-off-by: Rob Mulla <rob.mulla@gmail.com>
…shell scripts - added fallback format mapping to generate_support_matrices.sh for beta, experimental, planned, and unplanned to match README.md legend Signed-off-by: Rob Mulla <rob.mulla@gmail.com>
…tible Signed-off-by: Rob Mulla <rob.mulla@gmail.com>
RobMulla
force-pushed
the
fix-upstream-csv-formatting
branch
from
eb2fecd to
c8bcc78
Compare
jcyang43
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the support matrix generation scripts to natively output UI-formatted statuses (
✅ Passing,⚪ N/A,❓ Untested,❌ Failing) instead of relying on downstream Python scripts to parse emojis.Changes
record_step_result.sh: Modifies thecase inblock to output the actual user-facing strings instead of just emojis/raw words. Because this step outputs the data directly into the Buildkite metadata pipeline, every downstream script will natively pull the correct, formatted status without any post-processing required.generate_support_matrices.sh:process_kernel_matrix_to_pivotheader variables to output(Corr)and(Perf)instead of(Correctness)and(Performance)to save space.buildkite-agent meta-data getfallbacks fromN/Ato⚪ N/Ato match the UI scheme consistently.tests/test_generate_support_matrices.shwith a mockbuildkite-agentto guarantee the awk pivoting algorithm and fallback UI strings are correctly formatted before merging.This sets up the foundation for stripping out the redundant
update_all_matrices.pyand legacycombine_matrices.pyscripts from the downstream logic.