-
Notifications
You must be signed in to change notification settings - Fork 123
Format support matrix statuses natively in buildkite shell scripts #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RobMulla
wants to merge
5
commits into
main
Choose a base branch
from
fix-upstream-csv-formatting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9873dfb
feat: format support matrix statuses natively in buildkite shell scripts
RobMulla 08fad2e
test: add mock tests for generate_support_matrices formatting logic
RobMulla 6c8654b
feat: natively format experimental and planned statuses in buildkite …
RobMulla c8bcc78
fix: ensure generated support matrices script is MacOS bash 3.2 compa…
RobMulla 6de2881
Update default support matrix status to 'Untested' instead of 'N/A'
RobMulla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| #!/bin/bash | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| echo "Running Support Matrices Generator Tests..." | ||
|
|
||
| export TPU_VERSION="tpu6e" | ||
| export BUILDKITE_TAG="test_version" | ||
| TEST_DIR=$(mktemp -d) | ||
| export TEST_DIR | ||
| trap 'rm -rf "$TEST_DIR" v6' EXIT | ||
|
|
||
| cd "$(dirname "$0")/.." | ||
|
|
||
| # Mock buildkite-agent | ||
| buildkite-agent() { | ||
| local cmd="$1" | ||
| local subcmd="$2" | ||
| if [[ "$cmd" == "meta-data" && "$subcmd" == "get" ]]; then | ||
| local key="$3" | ||
| if [[ "$key" == "model-list" ]]; then | ||
| echo -e "test_model" | ||
| elif [[ "$key" == "feature-list" ]]; then | ||
| echo -e "kernel support matrix microbenchmarks" | ||
| elif [[ "$key" == "v6test_model_category" ]]; then | ||
| echo "text-only" | ||
| elif [[ "$key" == "v6test_model:UnitTest" ]]; then | ||
| echo "✅ Passing" | ||
| elif [[ "$key" == "v6test_model:Accuracy/Correctness" ]]; then | ||
| echo "❌ Failing" | ||
| elif [[ "$key" == "v6test_model:Benchmark" ]]; then | ||
| echo "⚪ N/A" | ||
| elif [[ "$key" == "v6kernel support matrix microbenchmarks_category" ]]; then | ||
| echo "kernel support matrix microbenchmarks" | ||
| else | ||
| echo "❓ Untested" | ||
| fi | ||
| elif [[ "$cmd" == "meta-data" && "$subcmd" == "set" ]]; then | ||
| echo "$3=$4" >> "$TEST_DIR/metadata.txt" | ||
| elif [[ "$cmd" == "artifact" && "$subcmd" == "upload" ]]; then | ||
| cp "$3" "$TEST_DIR/" | ||
| fi | ||
| } | ||
| export -f buildkite-agent | ||
|
|
||
| # Mock mapfile for MacOS compatibility (Bash 3.2 doesn't have it) | ||
| mapfile() { | ||
| local array_name="" | ||
| for arg in "$@"; do | ||
| if [[ "$arg" != "-t" ]]; then | ||
| array_name="$arg" | ||
| fi | ||
| done | ||
| local lines=() | ||
| while IFS= read -r line || [ -n "$line" ]; do | ||
| lines+=("$line") | ||
| done | ||
| if [[ -n "$array_name" ]]; then | ||
| eval "$array_name=(\"\${lines[@]}\")" | ||
| fi | ||
| } | ||
| export -f mapfile | ||
|
|
||
| # Set up mock microbenchmark input | ||
| mkdir -p v6 | ||
| cat << 'EOF' > v6/kernel_support_matrix_microbenchmarks.csv | ||
| kernels,CorrectnessTest,PerformanceTest,TPU Versions | ||
| fused_moe-w8a8,❓ Untested,❓ Untested,v6 | ||
| fused_moe-w8a16,✅ Passing,✅ Passing,v6 | ||
| fused_moe-w16a16,⚪ N/A,⚪ N/A,v6 | ||
| mla,✅ Passing,❓ Untested,v6 | ||
| generic ragged paged attention v3,✅ Passing,✅ Passing,v6 | ||
| EOF | ||
|
|
||
| # Execute the script | ||
| bash .buildkite/scripts/generate_support_matrices.sh > /dev/null | ||
|
|
||
| # Assertions | ||
| echo "Verifying Outputs..." | ||
| if ! grep -q "CI_TESTS_FAILED=true" "$TEST_DIR/metadata.txt"; then | ||
| echo "❌ ERROR: CI_TESTS_FAILED was not set to true despite test_model failing." | ||
| exit 1 | ||
| fi | ||
|
|
||
| PIVOT_CSV="$TEST_DIR/kernel_support_matrix-microbenchmarks.csv" | ||
| if [[ ! -f "$PIVOT_CSV" ]]; then | ||
| echo "❌ ERROR: Pivoted Microbenchmark CSV not uploaded." | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Verify header | ||
| if ! grep -q "Kernel,W16 A16 (Corr),W16 A16 (Perf),W8 A8 (Corr),W8 A8 (Perf),W8 A16 (Corr),W8 A16 (Perf),W4 A4 (Corr),W4 A4 (Perf),W4 A8 (Corr),W4 A8 (Perf),W4 A16 (Corr),W4 A16 (Perf)" "$PIVOT_CSV"; then | ||
| echo "❌ ERROR: Incorrect Pivot Header." | ||
| cat "$PIVOT_CSV" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Verify mla outputs correctly | ||
| if ! grep -q "\"mla\*\",✅ Passing,❓ Untested,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A" "$PIVOT_CSV"; then | ||
| echo "❌ ERROR: mla parsing failed or default values are incorrect." | ||
| cat "$PIVOT_CSV" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Verify fused_moe outputs correctly | ||
| if ! grep -q "\"fused_moe\",⚪ N/A,⚪ N/A,❓ Untested,❓ Untested,✅ Passing,✅ Passing,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A" "$PIVOT_CSV"; then | ||
| echo "❌ ERROR: fused_moe parsing failed." | ||
| cat "$PIVOT_CSV" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Verify string substitution correctness | ||
| if ! grep -q "\"generic ragged paged<br>attention v3\*\",✅ Passing,✅ Passing,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A,⚪ N/A" "$PIVOT_CSV"; then | ||
| echo "❌ ERROR: generic ragged paged attention v3 substitution failed." | ||
| cat "$PIVOT_CSV" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "✅ All tests passed successfully!" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.