-
-
Notifications
You must be signed in to change notification settings - Fork 12k
[Refactor] [2/N] Move tool parsers into the vLLM main directory #30675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] [2/N] Move tool parsers into the vLLM main directory #30675
Conversation
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
|
Documentation preview: https://vllm--30675.org.readthedocs.build/en/30675/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a refactoring that moves the tool parsers from vllm/entrypoints/openai/tool_parsers to a new top-level directory vllm/tool_parsers. The changes consist of moving files and updating all relevant import paths. I have reviewed the changes and they appear to be correct and complete within the scope of this PR. The refactoring is well-executed and I have no further comments.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
…-project#30675) Signed-off-by: chaunceyjiang <[email protected]>
…-project#30675) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Joachim Studnia <[email protected]>
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.