Skip to content

Conversation

@chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Dec 15, 2025

Purpose

Test Plan

vllm serve /home/jovyan/qwen3-8b --enable-auto-tool-choice  --tool-call-parser hermes --reasoning-parser qwen3   
...
(APIServer pid=95682) INFO 12-15 08:10:07 [launcher.py:46] Route: /v1/score, Methods: POST
(APIServer pid=95682) INFO 12-15 08:10:07 [launcher.py:46] Route: /rerank, Methods: POST
(APIServer pid=95682) INFO 12-15 08:10:07 [launcher.py:46] Route: /v1/rerank, Methods: POST
(APIServer pid=95682) INFO 12-15 08:10:07 [launcher.py:46] Route: /v2/rerank, Methods: POST
(APIServer pid=95682) INFO 12-15 08:10:07 [launcher.py:46] Route: /pooling, Methods: POST
(APIServer pid=95682) INFO:     Started server process [95682]
(APIServer pid=95682) INFO:     Waiting for application startup.
(APIServer pid=95682) INFO:     Application startup complet
╰─➤  python
Python 3.12.11 | packaged by conda-forge | (main, Jun  4 2025, 14:45:31) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
Ctrl click to launch VS Code Native REPL
>>> from vllm.entrypoints.openai.tool_parsers import ToolParser
<stdin>:1: DeprecationWarning: `vllm.entrypoints.openai.tool_parsers.ToolParser` has been moved to `vllm.tool_parsers.ToolParser`. The old name will be removed in v0.14.
>>> 

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify
Copy link

mergify bot commented Dec 15, 2025

Documentation preview: https://vllm--30675.org.readthedocs.build/en/30675/

@mergify mergify bot added documentation Improvements or additions to documentation deepseek Related to DeepSeek models frontend llama Related to Llama models qwen Related to Qwen models gpt-oss Related to GPT-OSS models tool-calling labels Dec 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a refactoring that moves the tool parsers from vllm/entrypoints/openai/tool_parsers to a new top-level directory vllm/tool_parsers. The changes consist of moving files and updating all relevant import paths. I have reviewed the changes and they appear to be correct and complete within the scope of this PR. The refactoring is well-executed and I have no further comments.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Dec 15, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 15, 2025 09:08
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 15, 2025
@DarkLight1337 DarkLight1337 merged commit 2a1776b into vllm-project:main Dec 15, 2025
50 of 51 checks passed
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Dec 15, 2025
joa-stdn pushed a commit to joa-stdn/vllm that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models documentation Improvements or additions to documentation frontend gpt-oss Related to GPT-OSS models llama Related to Llama models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants