[CI/Build] add directions for CPU image upload to Docker Hub#32032
[CI/Build] add directions for CPU image upload to Docker Hub#32032bigPYJ1151 merged 2 commits intovllm-project:mainfrom
Conversation
015846c to
e1e27e3
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the release pipeline to build and publish multi-architecture (x86_64 and arm64) CPU images to Docker Hub for each release. The changes are a good step towards providing official CPU base images. I've identified a critical issue with an invalid build argument in the arm64 build step and a high-severity inconsistency in the manual release annotation script which could cause manual steps to fail. Applying these suggestions will improve the correctness and robustness of the release process.
e1e27e3 to
45fd42d
Compare
45fd42d to
037b6ad
Compare
fadara01
left a comment
There was a problem hiding this comment.
Great work! Hosting CPU images on dockerhub is great step for improving CPU Backend UX.
I added some comments that we should address before moving forward with this.
|
cc: @bigPYJ1151 |
f4924eb to
67a1321
Compare
|
LGTM (untested). Curious to know if these CPU instruction issues will persist if/when opendatahub-io/llama-stack-distribution#203 merges |
fadara01
left a comment
There was a problem hiding this comment.
LGTM, thank you!
@bigPYJ1151 could you please have a look?
67a1321 to
85285b0
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
85285b0 to
04e66c2
Compare
|
Hi @nathan-weinberg Thanks for your efforts and sorry for the delay as I'm busy on other things recently. Right now all regular released images are manually uploaded to the hub. So I think we can just add CPU image upload instructions to the buildkite annotation as other images. I'll ask for creating a new namespace For the auto uploading, I think we'd better support it for all images to keep consistant. If you are interests on this please open a new PR and ask for review from CI maintainers. |
No worries at all 😄
Not opposed to any of this, but I admit I'm a bit lost in terms of what this means in terms of concrete actions I should take. It seems the former is something that can be done by removing some aspects of the PR and the latter would be a more holistic PR targeted towards moving all images to be auto-mirrored to Docker Hub. If I'm correct, please provide a code review when time permits for you so I have a better understanding as to what you would like to be kept in this PR and what you would like to defer to a followup. Thank you 🙏 |
04e66c2 to
9b1b252
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
9b1b252 to
5b1fc8d
Compare
e54f8c6 to
8113ee2
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
8113ee2 to
24a03d9
Compare
279d06a to
694f2a6
Compare
vLLM builds CPU images, but these are only put on ECR and not Docker Hub, where other public production images are hosted. While CPU images should not be used for production usage, they can be very good for CI and Developer usage. This commit updates the 'annotate-release.sh' script with directions on how to properly tag and upload these CPU images to Docker Hub Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Co-authored-by: Li, Jiang <bigpyj64@gmail.com> Signed-off-by: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com>
694f2a6 to
95cf8a3
Compare
bigPYJ1151
left a comment
There was a problem hiding this comment.
Hi @nathan-weinberg Thanks for your effort and patient. x86 and arm images will be uploaded to the hub starts from 0.16.0
|
Thank you for your reviews @bigPYJ1151 and @fadara01! |
…oject#32032) Signed-off-by: Nathan Weinberg <nweinber@redhat.com> Signed-off-by: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com> Co-authored-by: Li, Jiang <bigpyj64@gmail.com> Signed-off-by: Pai <416932041@qq.com>
…oject#32032) Signed-off-by: Nathan Weinberg <nweinber@redhat.com> Signed-off-by: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com> Co-authored-by: Li, Jiang <bigpyj64@gmail.com> Signed-off-by: Pai <416932041@qq.com>
…oject#32032) Signed-off-by: Nathan Weinberg <nweinber@redhat.com> Signed-off-by: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com> Co-authored-by: Li, Jiang <bigpyj64@gmail.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
… ECR CPU images for vLLM are now published to Docker Hub as part of the release pipeline (PR vllm-project#32032). Update the x86 and ARM CPU installation docs to reference the Docker Hub images instead of the AWS ECR images. Docker Hub image repository: vllm/vllm-openai-cpu - x86_64: vllm/vllm-openai-cpu:latest (multi-arch) or :latest-x86_64 - ARM64: vllm/vllm-openai-cpu:latest-arm64 - Versioned: vllm/vllm-openai-cpu:v<VERSION> Fixes vllm-project#33708
… ECR CPU images for vLLM are now published to Docker Hub as part of the release pipeline (PR vllm-project#32032). Update the x86 and ARM CPU installation docs to reference the Docker Hub images instead of the AWS ECR images. Docker Hub image repository: vllm/vllm-openai-cpu - x86_64: vllm/vllm-openai-cpu:latest (multi-arch) or :latest-x86_64 - ARM64: vllm/vllm-openai-cpu:latest-arm64 - Versioned: vllm/vllm-openai-cpu:v<VERSION> Fixes vllm-project#33708 Signed-off-by: Maxime Grenu <69890511+cluster2600@users.noreply.github.com>
…oject#32032) Signed-off-by: Nathan Weinberg <nweinber@redhat.com> Signed-off-by: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com> Co-authored-by: Li, Jiang <bigpyj64@gmail.com>
Purpose
It was suggested to me in #31749 to extend any CPU images off a base, but these base images are only put on ECR and not Docker Hub, where other public production images are hosted. While CPU images should not be used for production usage, they can be very good for CI and Developer usage.
This commit updates the
annotate-release.shscript with directions on how to properly tag and upload these CPU images to Docker HubTest Plan
Unfortunately I do not have the permissions or access to test this, thought I'm happy to perform any desired validations within my control
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Note
Publishes CPU release images to Docker Hub as part of the release pipeline, covering both architectures and multi-arch manifests.
.buildkite/release-pipeline.yamlto trigger CPU image publishingx86_64andarm64CPU images with ECR push, Docker Hub tagging/pushing, and commit/version tags (e.g.,$BUILDKITE_COMMIT-x86_64,v${release}-cpu-*)v${release}-cpuandlatest-cpumulti-arch manifests on Docker Hubdocker-loginplugin with Docker Hub credentials for publishing.buildkite/scripts/annotate-release.shto document CPU image tags and provide manual publish commandsWritten by Cursor Bugbot for commit e1e27e3cb050d8eb2c9f8b4fef63ce818ad263a0. This will update automatically on new commits. Configure here.
Note
Cursor Bugbot is generating a summary for commit 45fd42d9b299baf45ee1dbe4728a58e5301f1092. Configure here.