Add API support for updating specification of existing queues #111
Merged
volcano-sh-bot merged 1 commit intovolcano-sh:mainfrom May 30, 2025
Merged
Add API support for updating specification of existing queues #111volcano-sh-bot merged 1 commit intovolcano-sh:mainfrom
volcano-sh-bot merged 1 commit intovolcano-sh:mainfrom
Conversation
Member
Author
Member
Author
|
/assign @Monokaix |
13 tasks
Shrutim1505
force-pushed
the
backend-editing-queues
branch
4 times, most recently
from
e07158d to
9cd2695
Compare
Shrutim1505
force-pushed
the
backend-editing-queues
branch
3 times, most recently
from
404db12 to
523b4bb
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> Combined: frontend and merge from main Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> WIP: local changes to package-lock.json package.json Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> formatting checker Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> format check Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> edit functionality in form of queue Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> package-lock.json Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> permission added Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>
Shrutim1505
force-pushed
the
backend-editing-queues
branch
from
523b4bb to
545c89d
Compare
Contributor
|
@Shrutim1505: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
Author
Member
Author
|
this pr is interconnected with #92 |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements recent frontend changes to allow queue editing via both YAML and structured form inputs.
🔧 Key Changes:
Implemented PUT /api/queues/:name endpoint to allow partial or full updates to a queue's spec.
Validates incoming payload to ensure presence of required fields (metadata.name and spec).
Updates queue definitions in the underlying data store (e.g., Kubernetes, DB, or config map).
Returns updated queue specification in the response.
🧪 Testing:
Manually tested updates via both YAML and form-based editors in the frontend.
Verified correct rejection of invalid payloads (e.g., missing spec or malformed data).
Confirmed compatibility with frontend changes (e.g., reclaimable boolean field handling).