Implement Form-Based Editing for Queues#92
Implement Form-Based Editing for Queues#92Shrutim1505 wants to merge 1 commit intovolcano-sh:mainfrom
Conversation
Shrutim1505
force-pushed
the
editing_functionality_form
branch
2 times, most recently
from
d917bfa to
f3a6ecf
Compare
|
/assign @kevin-wangzefeng |
|
@Monokaix u can check this one |
I think the metadata part should not be displayed to let users edit them as it's meta data, and just display the fields in queue.spec is ok. |
|
As for queue, I think it can be same as creation of queue, you can just show editing of weight,capability,reclaimable,guarantee,parent,deserved,priority fileds in spec. @Shrutim1505 |
ok i will remove it |
ok |
actually i think in creation of queues users should have option of customisation , where as in editing existing queues can be edited |
Shrutim1505
force-pushed
the
editing_functionality_form
branch
from
ae65982 to
893b46e
Compare
Shrutim1505
changed the title
de6p
left a comment
de6p
left a comment
There was a problem hiding this comment.
Make use of a form library to improve the developer experience and eliminate redundant code.
one I have in mind is -> https://github.com/rjsf-team/react-jsonschema-form
Shrutim1505
force-pushed
the
editing_functionality_form
branch
from
f113d28 to
bf8744f
Compare
|
|
|
@JesseStutler backend is in #111 |
|
@Shrutim1505, please ensure that the backend code is implemented in the same PR, as it makes the review process easier. |
Shrutim1505
force-pushed
the
editing_functionality_form
branch
from
bf8744f to
5830cde
Compare
Shrutim1505
force-pushed
the
editing_functionality_form
branch
2 times, most recently
from
1f1c058 to
c5876f2
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Shrutim1505
force-pushed
the
editing_functionality_form
branch
from
c5876f2 to
34aac9e
Compare
Shrutim1505
force-pushed
the
editing_functionality_form
branch
2 times, most recently
from
d15f7bf to
97b137f
Compare
Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> editing queues in form Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>
Shrutim1505
force-pushed
the
editing_functionality_form
branch
from
f4ccba7 to
569ec47
Compare
|
@Monokaix please test it now |
5 participants
Added a feature to allow users to edit queues, jobs, and pods using a form-based interface within the dialog.
Introduced a toggle between YAML and Form views for easier editing.
Form fields dynamically render based on the provided data, allowing nested objects and arrays to be modified easily.
Added functionality to save the updated data, ensuring consistency with both YAML and form-based formats.
Improved user experience with validation to switch between modes only when valid YAML is provided.