Skip to content

Extra space removal #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Shrutim1505 wants to merge 1 commit into from
Closed

Extra space removal #358

Shrutim1505 wants to merge 1 commit into from

Conversation

@Shrutim1505
Copy link
Member

@Shrutim1505 Shrutim1505 commented Feb 15, 2025

Fixes #354

@volcano-sh-bot
Copy link
Collaborator

volcano-sh-bot commented Feb 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2025
@Shrutim1505
fixed docs alignment in mobile view
dc41716 
Signed-off-by: Shruti78 <[email protected]>

fixed docs alignment in mobile view

Signed-off-by: Shruti78 <[email protected]>

fixed docs alignment in mobile view

Signed-off-by: Shruti78 <[email protected]>

fixed responsiveness

Signed-off-by: Shruti78 <[email protected]>

 layout/fix

Signed-off-by: Shruti78 <[email protected]>

code updation

Signed-off-by: Shruti78 <[email protected]>

remove extra padding

Signed-off-by: Shruti78 <[email protected]>

unstaged changes

Signed-off-by: Shruti78 <[email protected]>
@Shrutim1505 Shrutim1505 force-pushed the extra-padding-removal branch from 6f43d81 to dc41716 Compare February 15, 2025 14:20
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2025
@Shrutim1505
Copy link
Member Author

Shrutim1505 commented Feb 15, 2025

/assign @Thor-wl

@Shrutim1505
Copy link
Member Author

Shrutim1505 commented Feb 15, 2025 •
edited
Loading

@Arhell @Monokaix check this one

Extended PR suggestion #359

@Monokaix
Copy link
Member

Monokaix commented Feb 17, 2025

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@Arhell
Copy link
Member

Arhell commented Feb 17, 2025 •
edited
Loading

/lgtm cancel

The white branch is made from this branch and not from the main one

@Shrutim1505 when you make a new branch, you need to do it from the master (main) branch and not from the one that was, as I wrote above.

That is, changes should not be repeated from branch to branch.

in other words, to make new changes you need to go to the main branch, make a new one and only then make changes and not repeat them.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@Shrutim1505
Copy link
Member Author

Shrutim1505 commented Feb 17, 2025 •
edited
Loading

I am opening a new PR and closing this one
@Arhell

@Arhell Arhell mentioned this pull request Feb 17, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arhell Arhell Awaiting requested review from Arhell

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@Monokaix Monokaix

@Arhell Arhell

@Thor-wl Thor-wl

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce Excessive Spacing Between "Why Volcano" and Feature Cards

5 participants

@Shrutim1505 @volcano-sh-bot @Monokaix @Arhell @Thor-wl