-
Notifications
You must be signed in to change notification settings - Fork 81
[doc] Add KubeRay ecosystem #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @seanlaii! It looks like this is your first PR to volcano-sh/website 🎉 |
Summary of ChangesHello @seanlaii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation that outlines the integration of KubeRay with Volcano, a powerful batch scheduler for Kubernetes. The added guide explains how this integration, available since KubeRay v1.5.1, enables advanced scheduling capabilities such as gang scheduling and network topology awareness for Ray workloads, thereby optimizing resource allocation and performance for distributed AI/ML applications running on Kubernetes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for integrating KubeRay with Volcano. The new page provides a comprehensive guide, including an introduction to KubeRay, setup instructions, configuration details, and example deployments for RayCluster and RayJob. The documentation is well-structured and clear. I have one suggestion to adjust the menu weight to avoid conflicts with existing documentation pages.
db06fa1 to
a2bc05c
Compare
|
Hi @win5923 @JesseStutler , could you take a look when you have a chance? Thank you! |
cccd97a to
f3dc97a
Compare
|
@seanlaii Does this pr have rendering problem? I see that all the netlify CI failed |
|
@seanlaii BTW, could you also add a Chinese version doc? Thanks! |
| # test-cluster-0-head-jj9bg 1/1 Running 0 36s | ||
| ``` | ||
|
|
||
| ##### RayJob Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add vcjob example? https://github.com/volcano-sh/volcano/blob/master/docs/user-guide/how_to_use_ray_plugin.md, in volcano v1.13 version, we have also supported using vcjob to create raycluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added.
02c7f47 to
46c8c28
Compare
I think it might be rate limited. It is working now. |
win5923
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the KubeRay part, thanks for your effort!
Signed-off-by: seanlaii <[email protected]>
46c8c28 to
2a1c482
Compare
|
@win5923 Thanks for the review! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler, win5923 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| # Add menu entry to sidebar. | ||
| linktitle = "Ray" | ||
| [menu.docs] | ||
| parent = "ecosystem" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find the zh doc in the website, I saw that the parent in other zh docs under "生态" is called "zoology", which is very weird, could you help us fix it and submit a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will send a PR.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
/kind documentation
What this PR does / why we need it:
KubeRay has integrated with Volcano to support gang-scheduling and network topology aware scheduling features.
We would like to a guideline in volcano's documentation.
Which issue(s) this PR fixes:
[Docs] Add KubeRay ecosystem doc in Volcano ray-project/kuberay#4289