chore(utils): AS-788 speed up docker image checking#406
Conversation
findtopher
left a comment
There was a problem hiding this comment.
I like 8 seconds instead of several minutes!
|
I thought the "why" of the script wasn't to validate that the images were in our private Docker Hub repository, but to validate that using a PAT, that the images could be downloaded. 🤔 |
|
@kevin-dimichel the intent of the script was originally to validate that our images are available and pullable before merging our helm chart (ie finalizing our release). I think that validating that the manifests exists accomplishes that!
|
Rationale
Last release, we realized that the
docker pullto validate if an image exists or not takes a LONG time. Luckily, there is an experimental docker command: docker manifestThis can help us check the manifest, not the pull, to see if an image exists on the remote.
Changes
Changes the
docker pullcommand todocker manifest inspectChecklist
Testing
Testing Failures
Testing Success (With Timing)