fix(theme): handle outline bottom overscroll - #5375
Merged
Merged
Conversation
bluwy
commented
Aug 14, 2026
| const innerHeight = window.innerHeight | ||
| const offsetHeight = document.body.offsetHeight | ||
| const isBottom = Math.abs(scrollY + innerHeight - offsetHeight) < 1 | ||
| const isBottom = scrollY + innerHeight - offsetHeight >= 0 |
Collaborator
Author
There was a problem hiding this comment.
When you scroll from top to bottom, the value (without abs) goes something like this:
-1000(top) ->0(bottom) ->+50(max overscrolled bottom)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When reaching the bottom of the page, the outline marker will always mark the last item. However, on Safari where you can overscroll the bottom (which have the elastic effect), the
Math.abswas preventing the detection for values that would go negative because of the overscroll.This PR updates the calculation to account for overscroll, so that the marker doesn't jump between the last and second last item during overscroll
Linked Issues
n/a
Additional Context
You can check the outline marker behaviour during overscroll like on this page: https://vitepress.dev/guide/i18n
Tip
The author can publish a preview release by commenting
/publishafter creating the PR.