Skip to content

fix(theme): handle outline bottom overscroll #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brc-dd merged 2 commits into from
Aug 18, 2026
+1 −1
Merged

fix(theme): handle outline bottom overscroll #5375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57942c3
fix(theme): handle outline bottom overscroll
bluwy Aug 14, 2026
5310511
refactor: invert to keep like before
bluwy Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/theme-default/composables/outline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function useActiveAnchor(
const scrollY = window.scrollY
const innerHeight = window.innerHeight
const offsetHeight = document.body.offsetHeight
const isBottom = Math.abs(scrollY + innerHeight - offsetHeight) < 1
const isBottom = scrollY + innerHeight - offsetHeight >= 0

@bluwy bluwy Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you scroll from top to bottom, the value (without abs) goes something like this:

  • -1000 (top) -> 0 (bottom) -> +50 (max overscrolled bottom)


// resolvedHeaders may be repositioned, hidden or fix positioned
const headers = resolvedHeaders
Expand Down