Standardize PHPdoc to use bool instead of boolean.#4931
Merged
demiankatz merged 6 commits intovufind-org:devfrom Dec 4, 2025
Merged
Standardize PHPdoc to use bool instead of boolean.#4931demiankatz merged 6 commits intovufind-org:devfrom
demiankatz merged 6 commits intovufind-org:devfrom
Conversation
ThoWagen
requested changes
Dec 4, 2025
Contributor
ThoWagen
left a comment
ThoWagen
left a comment
There was a problem hiding this comment.
There are some cases, the test does not catch.
- Class attributes: E.g.
protected $userHeadersin VuFind/Auth/Shibboleth.php - In merged types: E.g.
public function getUser()in VuFind/DigitalContent/FakeOverdriveConnector.php
See below, for a potential fix.
module/VuFind/tests/integration-tests/src/VuFindTest/Files/BadStringsTest.php
Outdated
Show resolved
Hide resolved
…StringsTest.php Co-authored-by: Thomas Wagener <wagener@hebis.uni-frankfurt.de>
Member
Author
|
Thanks for the suggestion, @ThoWagen -- good idea! I've just merged it, and we'll see if it triggers any errors that need fixing. |
Member
Author
|
Great improvements, @ThoWagen; I believe everything is fixed up now! |
ThoWagen
approved these changes
Dec 4, 2025
Contributor
ThoWagen
left a comment
ThoWagen
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds a test to prevent regressions.