Explain: Remove unused params #5017
Open
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maccabeelevine
commented
Jan 16, 2026
| $params->set('spellcheck', 'false'); | ||
| $explainParams = new ParamBag([ | ||
| 'fl' => 'id,score', | ||
| 'facet' => 'true', |
Member
Author
There was a problem hiding this comment.
This is the biggest problem -- there's a completely different facet API as part of the new JSON Request API, so we'd need to define what facets we want, etc. But I don't see facets being used within the Explain feature. So can we just remove it?
maccabeelevine
commented
Jan 16, 2026
| 'facet' => 'true', | ||
| 'debug' => 'true', | ||
| 'indent' => 'true', | ||
| 'param' => 'q', |
Member
Author
There was a problem hiding this comment.
I see no documentation on what this param element is supposed to do, and it seem to have no effect. There is a params element in the JSON Request API, but that's something entirely different. There's also a param element within the JSON Facet API's domain filters, but again that doesn't seem relevant here. And it seems to have no effect.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4991 I am migrating all Solr parameters to use the Solr JSON Request API. I am not sure how to migrate these parameters used in the Explain feature, and they don't seem to have any effect on the output anyway, so hoping we can just remove them.