Skip to content

Explain: Remove unused params #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maccabeelevine wants to merge 1 commit into
base: dev
Choose a base branch
from
+0 −2
Open

Explain: Remove unused params #5017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions module/VuFind/src/VuFind/Search/Solr/Explanation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,8 @@ public function performRequest($recordId)
$params->set('spellcheck', 'false');
$explainParams = new ParamBag([
'fl' => 'id,score',
'facet' => 'true',
Copy link
Member Author

@maccabeelevine maccabeelevine Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the biggest problem -- there's a completely different facet API as part of the new JSON Request API, so we'd need to define what facets we want, etc. But I don't see facets being used within the Explain feature. So can we just remove it?

'debug' => 'true',
'indent' => 'true',
'param' => 'q',
Copy link
Member Author

@maccabeelevine maccabeelevine Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no documentation on what this param element is supposed to do, and it seem to have no effect. There is a params element in the JSON Request API, but that's something entirely different. There's also a param element within the JSON Facet API's domain filters, but again that doesn't seem relevant here. And it seems to have no effect.

'echoParams' => 'all',
'explainOther' => 'id:"' . addcslashes($recordId, '"') . '"',
]);
Expand Down