T7836: move bind mount of /config to vyos-1x - #8
Merged
Conversation
We are removing the bind mount construction from the initrd components, as: (1) it is not needed before initialization in the vyos-1x vyos-router script (2) does not correctly update inodes on libc rename (3) fails on the livecd (cf. /var/log/live/boot.log)
Contributor
Author
|
Move to draft to investigate tmptest issue with image built from companion PRs. |
jestabro
marked this pull request as ready for review
September 19, 2025 17:05
11 tasks
Contributor
Author
|
The companion PR has been updated after discussion with @sarthurdev ; ready for review. |
sarthurdev
approved these changes
Sep 19, 2025
sarthurdev
left a comment
sarthurdev
left a comment
Member
There was a problem hiding this comment.
Moves bind mounts to vyos-router
c-po
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
NOTE: This will need to be merged along with vyos/vyos-1x#4732
We are removing the bind mount construction from the initrd components, as:
Begin: Configuring VyOS config path ... mount: mounting /root/lib/live/rw/config on /root/opt/vyatta/etc/config failed: No such file or directorywhich has necessitated workarounds, e.g., https://vyos.dev/T5524
During the interval between the merges of the two companion PRs, one would expect to see the following:
This PR merged first: an empty /config on installed image --- image will boot and all smoketests pass except for
https://github.com/vyos/vyos-1x/blob/current/smoketest/scripts/cli/test_service_dns_dynamic.py#L206-L212
This PR merged second: one would expect a recurrence of https://vyos.dev/T668
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-1x#4732
Proposed changes
How to test
Checklist: