T7836: move bind mount of /config to vyos-1x - #4732
Merged
Merged
Conversation
|
👍 |
Contributor
Author
|
Move to draft to investigate tmptest issue with image built from companion PRs. |
11 tasks
jestabro
marked this pull request as ready for review
September 19, 2025 17:05
We are removing the bind mount construction from the initrd components in live-boot, as: (1) it is not needed before initialization in the vyos-router script (2) does not correctly update inodes on libc rename (3) fails on the livecd (cf. /var/log/live/boot.log)
The mount point /opt/vyatta/etc/config is considered the source of truth whereas /config is simply a bind mount of convenience. As the latter is no longer defined at boot, all operations should use the former.
jestabro
force-pushed
the
simplified-bind-mount
branch
from
September 19, 2025 17:10
7af8300 to
2d32d32
Compare
Contributor
Author
|
Add commit with update for tpm. Discussed briefly with @sarthurdev , who will review. |
sarthurdev
approved these changes
Sep 19, 2025
sarthurdev
left a comment
sarthurdev
left a comment
Member
There was a problem hiding this comment.
Changes look good. TPM script issue is resolved and using vyos.defaults is a great idea.
|
CI integration ❌ failed! Details
|
c-po
approved these changes
Sep 20, 2025
c-po
left a comment
c-po
left a comment
Member
There was a problem hiding this comment.
Simplify code and remove additions from live-boot package. Maybe one day we can return to the upstrem live-boot package.
vyosbot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
NOTE: This will need to be merged along with vyos/live-boot#8
For success of the tpmtest, the modifications in vyos/vyos-build#1039 are not strictly required, but do enforce naming consistency.
We are removing the bind mount construction from the initrd components in live-boot, as:
Begin: Configuring VyOS config path ... mount: mounting /root/lib/live/rw/config on /root/opt/vyatta/etc/config failed: No such file or directorywhich has necessitated workarounds, e.g., https://vyos.dev/T5524
During the interval between merges of the this PR and the companion PR vyos/live-boot#8, one would expect to see the following:
This PR merged first: one would expect a recurrence of https://vyos.dev/T668
This PR merged second: an empty /config on installed image --- image will boot and all smoketests pass except for
https://github.com/vyos/vyos-1x/blob/current/smoketest/scripts/cli/test_service_dns_dynamic.py#L206-L212
NOTE: tests below do not reflect tests run will both companion PRs.
Types of changes
Related Task(s)
Related PR(s)
vyos/live-boot#8
vyos/vyos-build#1039
How to test / Smoketest result
Checklist: