VPP: T7175: Added sflow plugin to build by ServerForge · Pull Request #962 · vyos/vyos-build

ServerForge · 2025-05-12T17:04:26Z

Change summary

Added the VPP-Sflow plugin to the build.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, renaming)
Refactoring (no functional changes)
Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
Other (please describe):

Related Task(s)

https://vyos.dev/T7175

Related PR(s)

vyos-legacy/vyos-vpp#32
vyos/vyos-1x#4504

Checklist:

I have read the CONTRIBUTING document
I have linked this PR to one or more Phabricator Task(s)
My commit headlines contain a valid Task id
My change requires a change to the documentation
I have updated the documentation accordingly

Added Sflow plugin to VPP build.

github-actions · 2025-05-12T17:04:47Z

❌
PR title does not match the required format

Added Sflow plugin to VPP build.

sever-sever

Include sFlow plugin to VPP binary

github-actions · 2025-07-18T11:35:53Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

sever-sever · 2025-07-21T08:56:16Z

@ServerForge do you see the message regarding CLA? As the CI CLA Check does not pass. It cannot be merged until agreed/sign.
You should write in the comment. If you agree

I have read the CLA Document and I hereby sign the CLA

ServerForge · 2025-07-21T14:37:51Z

I don't usually get notifications for bot replies.

I have read the CLA Document and I hereby sign the CLA

evgsentrium · 2025-07-21T15:19:34Z

I don't usually get notifications for bot replies.

I have read the CLA Document and I hereby sign the CLA

@ServerForge it must be a separate comment that contains only this phrase without quotes "I have read the CLA Document and I hereby sign the CLA"

ServerForge · 2025-07-21T15:58:22Z

I have read the CLA Document and I hereby sign the CLA

c-po

Additional plugin build commands look sane.

dmbaturin · 2025-07-22T14:28:42Z

@ServerForge Thanks!

sever-sever · 2025-07-24T08:23:24Z

@ServerForge after merging the VPP binary cannot build

[2570/2817] Building C object CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/sflow.c.o
FAILED: CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/sflow.c.o 
/usr/bin/ccache /usr/lib/ccache/gcc -DHAVE_FCNTL64 -D_FORTIFY_SOURCE=2 -Dsflow_plugin_EXPORTS -I/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src -I/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/build-root/build-vpp-native/vpp/CMakeFiles -I/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins -I/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/build-root/build-vpp-native/vpp/CMakeFiles/plugins -I/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/build-root/build-vpp-native/vpp/CMakeFiles/plugins/sflow -fPIC -Wno-stringop-overflow -Wno-stringop-overread -Wno-array-bounds -g -Werror -Wall -Wno-address-of-packed-member -O3 -fstack-protector -fno-common -march=corei7 -mtune=corei7-avx -fvisibility=hidden -ffunction-sections -fdata-sections -MD -MT CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/sflow.c.o -MF CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/sflow.c.o.d -o CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/sflow.c.o -c /__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c: In function ‘total_drops’:
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c:247:8: error: unknown type name ‘clib_thread_index_t’; did you mean ‘vlib_thread_main_t’?
  247 |   for (clib_thread_index_t thread_index = 0; thread_index < smp->total_threads;
      |        ^~~~~~~~~~~~~~~~~~~
      |        vlib_thread_main_t
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c: In function ‘read_worker_fifos’:
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c:454:12: error: unknown type name ‘clib_thread_index_t’; did you mean ‘vlib_thread_main_t’?
  454 |       for (clib_thread_index_t thread_index = 0;
      |            ^~~~~~~~~~~~~~~~~~~
      |            vlib_thread_main_t
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c: In function ‘read_node_counters’:
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c:524:8: error: unknown type name ‘clib_thread_index_t’; did you mean ‘vlib_thread_main_t’?
  524 |   for (clib_thread_index_t thread_index = 0; thread_index < smp->total_threads;
      |        ^~~~~~~~~~~~~~~~~~~
      |        vlib_thread_main_t
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c: In function ‘sflow_set_worker_sampling_state’:
/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/src/plugins/sflow/sflow.c:638:8: error: unknown type name ‘clib_thread_index_t’; did you mean ‘vlib_thread_main_t’?
  638 |   for (clib_thread_index_t thread_index = 0; thread_index < smp->total_threads;
      |        ^~~~~~~~~~~~~~~~~~~
      |        vlib_thread_main_t
[2571/2817] Building C object CMakeFiles/plugins/rdma/CMakeFiles/rdma_plugin.dir/output.c.o
[2572/2817] Building C object CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/node.c.o
[2573/2817] Building C object CMakeFiles/plugins/sflow/CMakeFiles/sflow_plugin.dir/sflow_psample.c.o
[2574/2817] Building C object CMakeFiles/plugins/rdma/CMakeFiles/rdma_plugin_icl.dir/input.c.o
[2575/2817] Building C object CMakeFiles/plugins/rdma/CMakeFiles/rdma_plugin_skx.dir/input.c.o
[2576/2817] Building C object CMakeFiles/plugins/rdma/CMakeFiles/rdma_plugin_hsw.dir/input.c.o
[2577/2817] Building C object CMakeFiles/plugins/rdma/CMakeFiles/rdma_plugin.dir/input.c.o
ninja: build stopped: subcommand failed.
make[1]: *** [Makefile:700: vpp-build] Error 1
make[1]: Leaving directory '/__w/vyos-reusable-workflows/vyos-reusable-workflows/vyos-build/scripts/package-build/vpp/vpp/build-root'
make: *** [Makefile:711: pkg-deb] Error 2
cp: cannot stat 'build-root/*.deb': No such file or directory
I: build_cmd applying patch ../patches/vpp/0001-linux-cp-add-support-for-xfrm-netlink-notifcation.patch...
error: patch failed: src/plugins/linux-cp/CMakeLists.txt:26
Applying: linux-cp: add support for xfrm netlink notifcation
error: src/plugins/linux-cp/CMakeLists.txt: patch does not apply
error: src/plugins/linux-cp/lcp_ipsec.c: already exists in index
error: src/plugins/linux-cp/lcp_xfrm.h: already exists in index
error: src/plugins/linux-cp/lcp_xfrm_nl.c: already exists in index
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 linux-cp: add support for xfrm netlink notifcation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Failed to apply patch ../patches/vpp/0001-linux-cp-add-support-for-xfrm-netlink-notifcation.patch
I: Ensure Debian build dependencies are met
I: Tarball created: vyos-vpp-patches_current.tar.gz
I: Cleaned up build dependency packages
I: Tarball created: vpp-sflow_v1.0.01-1.tar.gz
I: Cleaned up build dependency packages
I: execute pre_build_hook for the package "vpp"
I: Tarball created: vpp_stable_2410.tar.gz
Command '# Patches for vpp should applied here
for patch in ../patches/vpp/*.patch; do
    echo "I: build_cmd applying patch $patch..."
    git -c user.email=maintainers@vyos.net -c user.name=vyos am "$patch" || { echo "Failed to apply patch $patch"; exit 1; }
done

make UNATTENDED=yes install-dep
make pkg-deb
cp build-root/*.deb ../
' returned non-zero exit status 1.
I: Source packages build failed, ignoring - building binaries only
Failed to build package vpp: Command '# Patches for vpp should applied here
for patch in ../patches/vpp/*.patch; do
    echo "I: build_cmd applying patch $patch..."
    git -c user.email=maintainers@vyos.net -c user.name=vyos am "$patch" || { echo "Failed to apply patch $patch"; exit 1; }
done

make UNATTENDED=yes install-dep
make pkg-deb
cp build-root/*.deb ../
' returned non-zero exit status 1.
I: Cleaned up build dependency packages
+ git config --global --unset-all url.https://@github.com/.insteadOf
+ cd vpp/build-root
+ sudo mkdir -p /opt/packages/current/vpp
+ sudo mv ./*.deb /opt/packages/current/vpp
mv: cannot stat './*.deb': No such file or directory
Error: Process completed with exit code 1.

ServerForge · 2025-07-24T12:40:25Z

May want to roll it back to v0.9.02-2 instead of v1.0.01-1 since i know it did build with the original version it was submitted with.

ServerForge · 2025-07-24T14:32:50Z

The current VPP version defined will build with v0.9.02-2 but not v1.0.01-1. v1.0.01-1 will build with stable/2506 however there seems to be a slight issue with some of the patches with the newer VPP versions.

VPP: T7175

c60403d

Added Sflow plugin to VPP build.

github-actions Bot assigned ServerForge May 12, 2025

github-actions Bot added the current VyOS rolling release label May 12, 2025

This was referenced May 12, 2025

VPP: T7175: Add sFlow conf mode CLI and startup template vyos-legacy/vyos-vpp#32

Merged

Sflow: T7175: Added VPP option vyos/vyos-1x#4504

Closed

ServerForge changed the title ~~VPP: T7175 Added sflow plugin to build~~ VPP: T7175: Added sflow plugin to build May 12, 2025

sever-sever requested changes May 13, 2025

View reviewed changes

Comment thread scripts/package-build/vpp/package.toml Outdated

sever-sever requested review from dmbaturin and zdc May 13, 2025 08:39

VPP: T7175

3595b49

Added Sflow plugin to VPP build.

sever-sever approved these changes May 15, 2025

View reviewed changes

sever-sever requested changes Jul 18, 2025

View reviewed changes

Comment thread scripts/package-build/vpp/package.toml Outdated

Merge branch 'vyos:current' into current

6b724a0

Sflow: T7175: Added VPP option

ed7fa5b

sever-sever approved these changes Jul 21, 2025

View reviewed changes

lemeshovich added a commit to vyos/vyos-cla-signatures that referenced this pull request Jul 21, 2025

@ServerForge has signed the CLA in vyos/vyos-build#962

f15f505

c-po approved these changes Jul 21, 2025

View reviewed changes

dmbaturin merged commit 1155ae7 into vyos:current Jul 22, 2025
7 of 10 checks passed

vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jul 22, 2025

ServerForge mentioned this pull request Jul 24, 2025

T7175: Added VPP option vyos/vyos-1x#4621

Merged

12 tasks

Navigation Menu

Uh oh!

VPP: T7175: Added sflow plugin to build - #962

VPP: T7175: Added sflow plugin to build#962
dmbaturin merged 4 commits into
vyos:currentfrom
ServerForge:current

ServerForge commented May 12, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

sever-sever left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

sever-sever commented Jul 21, 2025

Uh oh!

ServerForge commented Jul 21, 2025

Uh oh!

evgsentrium commented Jul 21, 2025 •

edited

Loading

Uh oh!

ServerForge commented Jul 21, 2025

Uh oh!

c-po left a comment

Uh oh!

Uh oh!

dmbaturin commented Jul 22, 2025

Uh oh!

sever-sever commented Jul 24, 2025

Uh oh!

ServerForge commented Jul 24, 2025

Uh oh!

ServerForge commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ServerForge commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change summary

Types of changes

Related Task(s)

Related PR(s)

Checklist:

Uh oh!

github-actions Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sever-sever left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sever-sever commented Jul 21, 2025

Uh oh!

ServerForge commented Jul 21, 2025

Uh oh!

evgsentrium commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ServerForge commented Jul 21, 2025

Uh oh!

c-po left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dmbaturin commented Jul 22, 2025

Uh oh!

sever-sever commented Jul 24, 2025

Uh oh!

ServerForge commented Jul 24, 2025

Uh oh!

ServerForge commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

ServerForge commented May 12, 2025 •

edited

Loading

github-actions Bot commented May 12, 2025 •

edited

Loading

github-actions Bot commented Jul 18, 2025 •

edited

Loading

evgsentrium commented Jul 21, 2025 •

edited

Loading