T8065: Dehardcode qemu settings to allow run tests on arch arm64 - #1073
T8065: Dehardcode qemu settings to allow run tests on arch arm64#1073sever-sever wants to merge 1 commit into
Conversation
|
👍 |
faa1b8a to
be1db15
Compare
|
@asklymenko add your review, please |
|
@huihuimoe, do you have a chance to check it? |
16b0ef3 to
582f2e3
Compare
1e3e98c to
4fb2337
Compare
c-po
left a comment
c-po
left a comment
There was a problem hiding this comment.
I'd remove the files
- tools/container/config.boot.default.amd64
- tools/container/config.boot.default.arm64
from this PR as they are related to VyOS as container. As this is an experimental feature, is it true that the serial console in an arm64 container is still ttyAMA0?
@c-po done, files removed! |
| if not os.path.exists('/dev/kvm'): | ||
| log.error('KVM not enabled on host, proceeding with software emulation') | ||
| sys.exit(1) | ||
| # Some arm platforms do not have kvm, for example Mac arm devices |
There was a problem hiding this comment.
This will change the behavior also for regular amd64 tests which is not a good idea. If MAC behaves different - add a condition to this check.
>>> import sys
>>> sys.platform
'linux'
There was a problem hiding this comment.
Another example - git arm64 runners do not support KVM
2 participants
Change summary
Dehardcode qemu settings to allow running smoketests on the arch
arm64I cannot completely check it, due to a lack of arm64 devices with a supported
/dev/kvmBut it is a good starting point. It could still fail on the arm64, but at least we allow it for future investigation.
Types of changes
Related Task(s)
Related PR(s)
#1074
Checklist: