Skip to content

Add id to dataset and dataset merge definitions #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfps merged 2 commits into from
Jan 23, 2026
Merged

Add id to dataset and dataset merge definitions #171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a95a5f
Add id to dataset and dataset merge definitions
rubensworks Jan 13, 2026
40ed9d6
Update spec/index.html
rubensworks Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,7 +1658,7 @@ <h2>RDF Datasets</h2>
between datasets would require RDF graph entailments between the graphs with the same <a>name</a>
(adding in empty graphs as required).</p>

<table>
<table id="dfn-rdf-dataset">
Copy link
Contributor

@afs afs Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDF Dataset is defined in RDF Concepts.
This causes the echidna error.

https://www.w3.org/TR/rdf12-concepts/#dfn-rdf-dataset

SPARQL Query uses the same algebraic formulation as semantics and the box there does not say "Definition".

https://www.w3.org/TR/sparql12-query/#sparqlDataset

RDF Semantics should not be claiming to define it. As it seems the current semantics doc is being read as defining RDF dataset, maybe the table text could changed be "RDF dataset" to avoid this confusion.

Copy link
Member Author

@rubensworks rubensworks Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the id here. Maybe we can create a separate issue for updating the text?

Copy link
Contributor

@afs afs Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #172.

<caption>Definition of an RDF dataset</caption>
<tr>
<td class="semantictable">
Expand All @@ -1674,7 +1674,7 @@ <h2>RDF Datasets</h2>
</tr>
</table>

<table>
<table id="dfn-rdf-dataset-merge">
Copy link
Member

@TallTed TallTed Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is the only change made by this PR, its title should change from

Add id to dataset and dataset merge definitions

to

Add id to definition of RDF dataset merge

<caption>Definition of RDF dataset merge</caption>
<tr>
<td class="semantictable">
Expand Down
Loading