Add id to dataset and dataset merge definitions #171
Conversation
In the SPARQL Update spec, we need to reference the RDF dataset merge definition. This PR adds an id for this definition, so we can properly reference it. Closes w3c/sparql-update#51
rubensworks
added
the
spec:editorial
spec/index.html
Outdated
| (adding in empty graphs as required).</p> | ||
|
|
||
| <table> | ||
| <table id="dfn-rdf-dataset"> |
There was a problem hiding this comment.
RDF Dataset is defined in RDF Concepts.
This causes the echidna error.
https://www.w3.org/TR/rdf12-concepts/#dfn-rdf-dataset
SPARQL Query uses the same algebraic formulation as semantics and the box there does not say "Definition".
https://www.w3.org/TR/sparql12-query/#sparqlDataset
RDF Semantics should not be claiming to define it. As it seems the current semantics doc is being read as defining RDF dataset, maybe the table text could changed be "RDF dataset" to avoid this confusion.
There was a problem hiding this comment.
I'll remove the id here. Maybe we can create a separate issue for updating the text?
pfps
left a comment
pfps
left a comment
There was a problem hiding this comment.
I think that this is OK now.
|
Editors - please can you merge this PR? It puts a |
|
@franconi Does this conflict with the other PRs? |
|
It's adjacent to a diff on #178 so git may declare a conflict but one that is simple to resolve. |
|
OK, I'll merge it. |
| </table> | ||
|
|
||
| <table> | ||
| <table id="dfn-rdf-dataset-merge"> |
There was a problem hiding this comment.
As this is the only change made by this PR, its title should change from
Add id to dataset and dataset merge definitions
to
Add id to definition of RDF dataset merge
In the SPARQL Update spec, we need to reference the RDF dataset merge definition. This PR adds an id for this definition, so we can properly reference it.
(requested reviews from the editors of both the RDF 1.2 Semantics and SPARQL 1.2 Update specs)
Closes w3c/sparql-update#51
Preview | Diff