Skip to content

Update RDF dataset merge definition #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
franconi wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update RDF dataset merge definition #178

franconi wants to merge 10 commits into from

Conversation

@franconi
Copy link
Contributor

@franconi franconi commented Jan 21, 2026 •
edited by pr-preview bot
Loading

As per issue #173

Preview | Diff

@franconi franconi requested review from afs, doerthe and pfps January 21, 2026 17:17
@franconi franconi added the ms:CR Milestone: Candidate Recommendation label Jan 21, 2026
@franconi
Copy link
Contributor Author

franconi commented Jan 21, 2026

Closes #173

@afs
Copy link
Contributor

afs commented Jan 22, 2026

Display (does not update): https://rawcdn.githack.com/w3c/rdf-semantics/6ba37df6447be1812d5899ea88f3c5d1834a2dbe/spec/index.html#rdf_datasets

@afs
Copy link
Contributor

afs commented Jan 22, 2026

Is there going to be a follow-up to this PR to remove the definition of RDF Dataset (being updated by #172)?

This PR makes it redundant. The RDF Datasets Definition includes notation such as:

... { G, (, G1), (, G2), . . . (, Gn) } ...

which is only in RDF Semantics because the notation is used for RDF Dataset merge.

@franconi
Copy link
Contributor Author

franconi commented Jan 22, 2026

Is there going to be a follow-up to this PR to remove the definition of RDF Dataset (being updated by #172)?

This PR makes it redundant. The RDF Datasets Definition includes notation such as:

... { G, (, G1), (, G2), . . . (, Gn) } ...

which is only in RDF Semantics because the notation is used for RDF Dataset merge.

Right. I am removing the definition in this PR, making PR #172 redundant.

@franconi
Copy link
Contributor Author

franconi commented Jan 22, 2026

Removed the RDF Datasets Definition.

@franconi
Copy link
Contributor Author

franconi commented Jan 22, 2026

Closes PR #172

@franconi
Copy link
Contributor Author

franconi commented Jan 22, 2026

Display: https://rawcdn.githack.com/w3c/rdf-semantics/118ed502cba827bd14badec4c4103bc687a3d06a/spec/index.html#rdf_datasets

@pfps
Copy link
Contributor

pfps commented Jan 22, 2026

It appears to me that this definition would remove from the default graph any triple that was also in any named graph.

Why not use the previous definition plus the initial standardize apart and replace merge with union, although they are the same as there are no shared blank node names.

@afs
Copy link
Contributor

afs commented Jan 22, 2026

It appears to me that this definition would remove from the default graph any triple that was also in any named graph.

Use "" as a label for the default graphs.

@franconi
Copy link
Contributor Author

franconi commented Jan 22, 2026

I used the special label "default" as label for the default graph. Committed.

@pfps
Copy link
Contributor

pfps commented Jan 22, 2026

Yes, but why all this new way of doing things when the old way worked fine with the addition of the standardize apart initial step?

@franconi
Copy link
Contributor Author

franconi commented Jan 22, 2026

Yes, but why all this new way of doing things when the old way worked fine with the addition of the standardize apart initial step?

It is much simpler, and it generalises to n datasets.

@afs
Copy link
Contributor

afs commented Jan 22, 2026

Tracking current: https://raw.githack.com/w3c/rdf-semantics/Dataset-fix/spec/index.html#rdf_datasets

TallTed
TallTed reviewed Jan 23, 2026
View reviewed changes
TallTed
TallTed reviewed Jan 23, 2026
View reviewed changes
@afs afs mentioned this pull request Jan 23, 2026
Merged
@afs
Copy link
Contributor

afs commented Jan 23, 2026

Rebased to main to integrate PR #171; resolve conflict; replace a use of tabs by spaces like the lines around it.

TallTed
TallTed reviewed Jan 28, 2026
View reviewed changes
TallTed
TallTed reviewed Jan 28, 2026
View reviewed changes
franconi and others added 5 commits January 28, 2026 22:18
@franconi @afs
Update RDF dataset merge definition in index.html
b9ead72
@franconi @afs
Remove RDF dataset definition
029165c 
Removed the definition of an RDF dataset from the HTML specification.
@franconi @afs
Update RDF dataset merge labeling (to include default graph)
859227a
@franconi @TallTed @afs
Deleted redundant whitespace
de8e4fa 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@franconi @TallTed @afs
Added line break
556fcd8 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@afs
Copy link
Contributor

afs commented Jan 28, 2026

Conflicts resolved; #172 touches RDF Dataset definition whereas this PR removes that definition.

franconi and others added 2 commits January 29, 2026 12:19
@franconi @TallTed
better wording
8a49ad6 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@franconi @TallTed
wording from definition to procedure
6ea60b9 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
afs
afs reviewed Jan 29, 2026
View reviewed changes
@franconi
Copy link
Contributor Author

franconi commented Jan 29, 2026

Preview: https://rawcdn.githack.com/w3c/rdf-semantics/1a96b5becc00eedf4c1b494349f91f0230e9a5de/spec/index.html#rdf_datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afs afs afs approved these changes

@doerthe doerthe Awaiting requested review from doerthe

@pfps pfps Awaiting requested review from pfps

+1 more reviewer

@TallTed TallTed TallTed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ms:CR Milestone: Candidate Recommendation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@franconi @afs @pfps @TallTed