Skip to content

emulate geolocation POSITION_UNAVAILABLE error #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadym-chromium merged 7 commits into from
Apr 30, 2025
Merged

emulate geolocation POSITION_UNAVAILABLE error #911

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f871ebe
emulate geolocation error
sadym-chromium Apr 29, 2025
240ac5f
do not let both coordinates and error empty
sadym-chromium Apr 29, 2025
2abb684
emulate only "positionUnavailable"
sadym-chromium Apr 29, 2025
c91ae18
Update index.bs
sadym-chromium Apr 30, 2025
c6a9a9e
return `GeolocationPositionError` instance
sadym-chromium Apr 30, 2025
f8bbe99
add a note
sadym-chromium Apr 30, 2025
968c191
remove excessive validation
sadym-chromium Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5623,7 +5623,8 @@ The <dfn export for=commands>emulation.setGeolocationOverride</dfn> command modi
)

emulation.SetGeolocationOverrideParameters = {
coordinates: emulation.GeolocationCoordinates / null,
? coordinates: emulation.GeolocationCoordinates / null,
? error: emulation.GeolocationPositionError / null,
? contexts: [+browsingContext.BrowsingContext],
? userContexts: [+browser.UserContext],
}
Expand All @@ -5637,6 +5638,11 @@ The <dfn export for=commands>emulation.setGeolocationOverride</dfn> command modi
? heading: (0.0...360.0) / null .default null,
? speed: (float .ge 0.0) / null .default null,
}

emulation.GeolocationPositionError = {
code: js-uint,
message: text
}
</pre>
</dd>
<dt>Result Type</dt>
Expand All @@ -5651,9 +5657,24 @@ The <dfn export for=commands>emulation.setGeolocationOverride</dfn> command modi

The [=remote end steps=] with |command parameters| are:

1. If |command parameters| [=map/contains=] "<code>altitudeAccuracy</code>"
and |command parameters| doesn't [=map/contain=] "<code>altitude</code>",
return [=error=] with [=error code=] [=invalid argument=].
1. If |command parameters| [=map/contains=] "<code>coordinates</code>"
and |command parameters| [=map/contains=] "<code>error</code>", return [=error=]
with [=error code=] [=invalid argument=].

1. If |command parameters| [=map/contains=] "<code>coordinates</code>" and
|command parameters|["<code>coordinates</code>"] [=map/contains=]
"<code>altitudeAccuracy</code>" and
|command parameters|["<code>coordinates</code>"] doesn't [=map/contain=]
"<code>altitude</code>", return [=error=] with [=error code=]
[=invalid argument=].

1. If |command parameters| [=map/contains=] "<code>coordinates</code>", let
|emulated position data| be |command parameters|["<code>coordinates</code>"].

1. Otherwise, let |emulated position data| be |command parameters|["<code>error</code>"].

Note: Setting either the <code>coordinates</code> parameter or the <code>error</code>
parameter to <code>null</code> removes the geolocation override.

1. If |command parameters| [=map/contains=] "<code>userContexts</code>"
and |command parameters| [=map/contains=] "<code>context</code>",
Expand All @@ -5675,7 +5696,7 @@ The [=remote end steps=] with |command parameters| are:

1. For each |user context| of |user contexts|:

1. [=map/Set=] [=geolocation overrides map=][|user context|] to |command parameters|["<code>coordinates</code>"].
1. [=map/Set=] [=geolocation overrides map=][|user context|] to |emulated position data|.

1. [=list/For each=] |top-level traversable| of the list of all [=/top-level traversables=]
whose [=associated user context=] is |user context|:
Expand All @@ -5684,7 +5705,7 @@ The [=remote end steps=] with |command parameters| are:

1. For each |navigable| of |navigables|:

1. [=Set emulated position data=] with |navigable| and |command parameters|["<code>coordinates</code>"].
1. [=Set emulated position data=] with |navigable| and |emulated position data|.

1. Return [=success=] with data null.

Expand Down