emulate geolocation POSITION_UNAVAILABLE error#911
Merged
sadym-chromium merged 7 commits intomainfrom Apr 30, 2025
Merged
Conversation
nd fix `altitudeAccuracy` + `altitude` access path
OrKoN
approved these changes
Apr 29, 2025
sadym-chromium
changed the title
sadym-chromium
force-pushed
the
sadym/geolocation-error
branch
3 times, most recently
from
5d2968a to
e8f8d62
Compare
sadym-chromium
force-pushed
the
sadym/geolocation-error
branch
from
e8f8d62 to
2abb684
Compare
sadym-chromium
commented
Apr 29, 2025
whimboo
reviewed
Apr 29, 2025
Co-authored-by: Henrik Skupin <mail@hskupin.info>
sadym-chromium
force-pushed
the
sadym/geolocation-error
branch
from
1ce3afb to
c91ae18
Compare
sadym-chromium
force-pushed
the
sadym/geolocation-error
branch
from
1c8848b to
c6a9a9e
Compare
OrKoN
approved these changes
Apr 30, 2025
Contributor
Author
|
@juliandescottes any other concerns? |
whimboo
reviewed
Apr 30, 2025
github-actions bot
added a commit
that referenced
this pull request
Apr 30, 2025
SHA: 5e3b177 Reason: push, by sadym-chromium Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sadym-chromium
added a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
Apr 30, 2025
sadym-chromium
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 5, 2025
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 12, 2025
…ilable", Automatic update from web-platform-tests [wdspec] test geolocation "positionUnavailable" (#52250) Spec: w3c/webdriver-bidi#911 -- wpt-commits: 4e5ff79b8032c5762b1548341324a7d357301c2d wpt-pr: 52250 Differential Revision: https://phabricator.services.mozilla.com/D248839
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 12, 2025
…ilable", Automatic update from web-platform-tests [wdspec] test geolocation "positionUnavailable" (#52250) Spec: w3c/webdriver-bidi#911 -- wpt-commits: 4e5ff79b8032c5762b1548341324a7d357301c2d wpt-pr: 52250 Differential Revision: https://phabricator.services.mozilla.com/D248839
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
…ilable", Automatic update from web-platform-tests [wdspec] test geolocation "positionUnavailable" (#52250) Spec: w3c/webdriver-bidi#911 -- wpt-commits: 4e5ff79b8032c5762b1548341324a7d357301c2d wpt-pr: 52250 Differential Revision: https://phabricator.services.mozilla.com/D248839 UltraBlame original commit: 3870830f0eaf15001a0f63b3dc530a0616462516
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
…ilable", Automatic update from web-platform-tests [wdspec] test geolocation "positionUnavailable" (#52250) Spec: w3c/webdriver-bidi#911 -- wpt-commits: 4e5ff79b8032c5762b1548341324a7d357301c2d wpt-pr: 52250 Differential Revision: https://phabricator.services.mozilla.com/D248839 UltraBlame original commit: 3870830f0eaf15001a0f63b3dc530a0616462516
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
…ilable", Automatic update from web-platform-tests [wdspec] test geolocation "positionUnavailable" (#52250) Spec: w3c/webdriver-bidi#911 -- wpt-commits: 4e5ff79b8032c5762b1548341324a7d357301c2d wpt-pr: 52250 Differential Revision: https://phabricator.services.mozilla.com/D248839 UltraBlame original commit: 3870830f0eaf15001a0f63b3dc530a0616462516
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPT tests: web-platform-tests/wpt#52250
I don't think we need to emulate other errors (PERMISSION_DENIED, TIMEOUT), as it can be tested without emulation.
The geolocation emulation spec was written to support any kind of error emulations, which is an overkill, and is tricky to be implemented, so I propose to limit the error emulation only to "POSITION_UNAVAILABLE" on the WebDriver BiDi side.
From geolocation spec: