Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toasts and search #299

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Toasts and search #299

merged 3 commits into from
Oct 31, 2024

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Oct 31, 2024

Fixes one issue and implements one feature:

  • Removes Bootstrap toast styles, which interfere with the Read the Docs Addons’ "readthedocs-notification" component, which also uses the toast class. We don’t need this part of Bootstrap so might as well remove it.
  • Triggers the Read the Docs Addons’ search modal, if RTD Addons are initialised on the page.

Both of those issues are impossible to properly test locally but can be checked with the PR preview build.

@thibaudcolas thibaudcolas added bug Something isn't working enhancement New feature or request labels Oct 31, 2024
Copy link
Member

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Thank you!

@thibaudcolas thibaudcolas merged commit 9dae618 into main Oct 31, 2024
3 of 4 checks passed
@thibaudcolas thibaudcolas deleted the toasts-and-search branch October 31, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants