feat(disclosure): ディスクロージャーパターンと例の日本語翻訳 #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for waic-apg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This pull request translates the disclosure pattern documentation and examples from English to Japanese. It includes updating the language attribute to lang="ja" and translating all text content while maintaining the technical structure and accessibility features.
- Updates language attributes to Japanese across all HTML files
- Translates pattern documentation, example descriptions, and accessibility features
- Translates keyboard interaction tables and ARIA attribute descriptions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| disclosure-pattern.html | Translates main pattern documentation to Japanese |
| disclosure-navigation.html | Translates navigation disclosure example |
| disclosure-navigation-hybrid.html | Translates hybrid navigation example with top-level links |
| disclosure-image-description.html | Translates image description disclosure example |
| disclosure-faq.html | Translates FAQ disclosure example |
| role-coverage.csv | Updates alert example references to Japanese |
| prop-coverage.csv | Updates property coverage references to Japanese |
| coverage-and-quality-report.html | Updates coverage report references to Japanese |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ef81sp
force-pushed
the
rikegami/disclosure-ja
branch
from
fe0c27c to
09862f3
Compare
ef81sp
commented
Dec 3, 2025
| When the controlled content is hidden, the button is often styled as a typical push button with a right-pointing arrow or triangle to hint that activating the button will display additional content. | ||
| When the content is visible, the arrow or triangle typically points down. | ||
| ディスクロージャーは、コンテンツを折りたたんだり（非表示）、展開したり（表示）できるウィジェットです。 | ||
| ディスクロージャー<a href="../button/button-pattern.html">ボタン</a>と、ボタンによって表示/非表示が制御されるコンテンツのセクションの 2 つの要素があります。 |
Contributor
Author
There was a problem hiding this comment.
theを訳出した方がわかりやすいでしょう
Suggested change
| ディスクロージャー<a href="../button/button-pattern.html">ボタン</a>と、ボタンによって表示/非表示が制御されるコンテンツのセクションの 2 つの要素があります。 | |
| ディスクロージャー<a href="../button/button-pattern.html">ボタン</a>と、そのボタンによって表示/非表示が制御されるコンテンツのセクションの 2 つの要素があります。 |
Comment on lines
+45
to
+46
| <li><kbd>Enter</kbd>: ディスクロージャーコントロールを作動させ、ディスクロージャーコンテンツの表示/非表示を切り替えます。</li> | ||
| <li><kbd>Space</kbd>: ディスクロージャーコントロールを作動させ、ディスクロージャーコンテンツの表示/非表示を切り替えます。</li> |
Contributor
Author
There was a problem hiding this comment.
visibilityの訳ですね。直訳で「可視性」などでもよいですが、「表示/非表示」の方がわかりやすく感じます。このままでよいのではないでしょうか。
| </li> | ||
| <li> | ||
| Optionally, the element with role <code>button</code> has a value specified for <a href="#aria-controls" class="property-reference">aria-controls</a> that refers to the element that contains all the content that is shown or hidden. | ||
| 任意で、<code>button</code> ロールを持つ要素には、表示又は非表示にされるすべてのコンテンツを含む要素を参照する <a href="#aria-controls" class="property-reference">aria-controls</a> に値が指定されています。 |
Contributor
Author
There was a problem hiding this comment.
直訳の方がわかりやすく感じます
Suggested change
| 任意で、<code>button</code> ロールを持つ要素には、表示又は非表示にされるすべてのコンテンツを含む要素を参照する <a href="#aria-controls" class="property-reference">aria-controls</a> に値が指定されています。 | |
| 任意で、<code>button</code> ロールを持つ要素は、表示又は非表示にされるすべてのコンテンツを含む要素を参照する <a href="#aria-controls" class="property-reference">aria-controls</a> 向けに指定された値を持っています。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連Issue
レビュワーに見てもらいたい箇所
翻訳チェックリスト
html要素にlang="ja"属性を付与するh1要素の直下に翻訳元リビジョンを記載する