fix(minimal/client): do not pass findSourceMapURL unnecessarily#1993
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
hi-ogawa
left a comment
There was a problem hiding this comment.
Yes, this looks like a same thing as https://github.com/vitejs/vite-plugin-react/blob/87e505bedaa60bf3f061cb0d4ecd0cdc550b5567/packages/plugin-rsc/src/react/browser.ts#L53-L65
| useState, | ||
| } from 'react'; | ||
| import type { ReactNode } from 'react'; | ||
| import RSDWClient from 'react-server-dom-webpack/client'; |
There was a problem hiding this comment.
I noticed react-server-dom-webpack/client is imported but this always gets swapped @vitejs/plugin-rsc/browser so it should be fine.
waku/packages/waku/src/lib/vite-plugins/patch-rsdw.ts
Lines 26 to 42 in 2ce74ee
We should be able to actually rewrite this line directly, but think one issue is I need to type @vitejs/plugin-rsc/browser more thoroughly.
#1984 (comment)