Skip to content

fix(minimal/client): do not pass findSourceMapURL unnecessarily #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dai-shi merged 1 commit into from
Mar 20, 2026
Merged

fix(minimal/client): do not pass findSourceMapURL unnecessarily #1993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions packages/waku/src/minimal/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,6 @@ const mergeElementsPromise = (
return getCached(getResult, cache2, b);
};

// Keep this local for now.
// Importing the helper from @vitejs/plugin-rsc pulls in its browser runtime,
// which breaks Node-side tests.
// TODO
// If upstream exposes a lighter shared entry for this helper, switch to that.
const findSourceMapURL = (fileName: string, environmentName: string) => {
const url = new URL('/__vite_rsc_findSourceMapURL', import.meta.url);
url.searchParams.set('filename', fileName);
url.searchParams.set('environmentName', environmentName);
return url.toString();
};

type SetElements = (
updater: (prev: Promise<Elements>) => Promise<Elements>,
) => void;
Expand Down Expand Up @@ -207,10 +195,7 @@ const fetchRscInternal: FetchRscInternal = (
return createFromFetch<Elements>(checkStatus(responsePromise), {
callServer: (funcId: string, args: unknown[]) =>
unstable_callServerRsc(funcId, args, () => fetchRscStore),
...(import.meta.hot && {
debugChannel: debug?.debugChannel,
findSourceMapURL,
}),
debugChannel: debug?.debugChannel,
temporaryReferences,
});
};
Expand Down
Loading