fix: tracing validation fields always null (#448) - #476
Merged
Conversation
`::tracing/validation` was stored on the context map but read alongside `::tracing/parsing` (which lives on the parsed-query map), causing the validation startOffset and duration to always be nil in tracing output. Store ::tracing/validation on the prepared query map, consistent with ::tracing/parsing, and read it from parsed-query in execute-query. 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca-agent <git@eca.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::tracing/validationwas stored on thecontextmap butexecute-queryreads it alongside::tracing/parsing(which lives on theparsed-querymap), causing validationstartOffsetanddurationto always benilin tracing output::tracing/validationon the prepared query map, consistent with::tracing/parsing, and reads it fromparsed-queryinexecute-queryparsingandvalidationtracing phases have non-nilstartOffsetand positivedurationFixes #448
🤖 Generated with eca