Launcher / Log Update

[patrick-gu]

Description

I changed X and Y to accomplish Z.

This PR closes #182 .

Developer Testing

Here's what I did to test my changes:

• Ran A
• Ran B
• Ran C

Reviewer Testing

Here's what you should do to quickly validate my changes:

• Run D and check output

---

This change is 

[zangjiucheng]

I will continue to work for this PR, which I believe is something we really need right now.

[zangjiucheng]

Description

• This is an enhance implement of Add Argument Support to Launcher #182, where the launcher has been used completely outdate of our code.
• This feature implements the functional use cases of the new version of the launcher.

• Finish implement of launcher arg support based on Patrick previous modify.
• Support stdout to the screen but not redirect to the log files
• Support --text mode argument input
• Modify log file name with temp_stamp for permeant storage log for analysis.
• Tiny fix for log tool with args index for general case

This PR closes #182 .

Known Issue

• Stdout feature control not support --text version, (For purpose to use cli we want to see output, then just Enable stdout by default)

Developer Testing

Here's what I did to test my changes:

• Run any combination with launcher to test if program can functional work.

Reviewer Testing

Here's what you should do to quickly validate my changes:

• Same as Developer Testing

[patrick-gu]

Left some comments about the code. Also it doesn't seem to work for me, I get the error:

Running in GUI mode
Launching... Run commands: [['venv/Scripts/python', '-m', 'omnibus', False], ['venv/Scripts/python', 'sources/fakeni/main.py', False], ['venv/Scripts/python', 'sources/parsley/main.py', '--fake', False], ['venv/Scripts/python', 'sinks/dashboard/main.py', True], ['venv/Scripts/python', 'sinks/printer/main.py', False]]
Traceback (most recent call last):
  File "...\omnibus\launcher.py", line 409, in <module>
    main()
  File "...\omnibus\launcher.py", line 403, in main
    gui_launcher.subprocess()
  File "...\omnibus\launcher.py", line 159, in subprocess
    process = subprocess.Popen(launch_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python312\Lib\subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Program Files\Python312\Lib\subprocess.py", line 1538, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified

[patrick-gu]

is there a reason for this?

[zangjiucheng]

I did this because for some reason, if I use ~ relative to the home directory on a unix-like system, it pops up an error that the system cannot find the specified file. I think the reason for the error popping up before you mentioned is probably because I switched this... I think I need to add an OS check for this.

[patrick-gu]

This is really small nitpick. Although the Python documentation officially suggests you can do this, I would be inclined to avoid this. The reason is because we don't know if .connect will always only give us one argument, and I assume that nobody really wants to take the time to check (and just looking at the [outdated] docs quickly is unclear https://doc.qt.io/qtforpython-5/PySide2/QtCore/Signal.html#PySide2.QtCore.Signal.connect). I think it's better to make sure it's clear that this is a function with arity 1 (i.e. takes exactly one argument).

[zangjiucheng]

Hi :)) I didn't think about a good way to pass only one argument because I have no idea how to edit state binding to a list. But I did use another solution with partial function to ensure it take two argument.

[zangjiucheng]

I did test this script on the Windows and Linux also, unfortunately I cannot reproduce the issue [WinError 2] The system cannot find the file specified. Can you try again please? Maybe it been fixed in some comments I don't really noticed. Thanks for your review :))

[patrick-gu]

Sorry I never responded to this! I've figured out that the issue was that I created my venv in a folder called .venv instead of venv. It shouldn't be an issue since the recommended setup instructions are compatible with this. Also, I haven't tested it thoroughly, but it does seem to work, so thank you :)

[zangjiucheng]

@patrick-gu No worries :). I just get some free time today to review some code before. I did test more with more combination of sources and sinks. It should be working well! If any others come up, we can still fix it later lol. Merry Christmas 🎄