Skip to content

Uconn flowsheet with ASM3 #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adam-a-a wants to merge 150 commits into
base: main
Choose a base branch
from
Draft

Uconn flowsheet with ASM3 #1599

adam-a-a wants to merge 150 commits into from

Conversation

@adam-a-a
Copy link
Contributor

@adam-a-a adam-a-a commented Jun 26, 2025

Fixes/Resolves:

Summary/Motivation:

This PR incorporates ASM3 from PR #1593 and includes a new activated sludge process flowsheet to represent Uconn use case shared by Stuber PSOR lab.

DRAFT: still need to add tests and perhaps validate against available results from Stuber group

Changes proposed in this PR:

  • add new flowsheet
  • compatible with asm1 and asm3 so far

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@luohezhiming
add
7d35890
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
4766c52
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
ef81bae
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
168bbaf
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
a09b4e9
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
44a22e8
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
1c1a135
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
401f997
@luohezhiming
delete redundant files
258f6fe
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
2c994c3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
5b6baed
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
0afa551
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
479fb6d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
b393ed0
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
708ad0a
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
5a69761
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
112415a
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
93737c0
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
3162e34
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
637b32d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
ea4e066
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
84a2900
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
17bc5e3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
f816483
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
fea68e3
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
c19fba5
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
0754d21
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
9dcece1
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
a5325c9
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
c4bc3ef
luohezhiming and others added 22 commits March 19, 2025 13:00
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
17b72e4
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
64bb52d
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
585e38f
@adam-a-a
first draft of alternative activated sludge process (reactors only)
d7c1d78
@adam-a-a
make COD_to_SS a param on ASM1 for consistency
0752d35
@adam-a-a
tinkering with scaling
8bd13db
@luohezhiming
ASM3 development
f9048ec
@luohezhiming
Completed reaction package and properties package
cb4c637
@luohezhiming
add test file
3df8224
@luohezhiming
add test file
0368330
@luohezhiming
Reaction and properties test pass
bb34640
@luohezhiming
revise test
220d0c6
@luohezhiming
code linting
d5135cc
@adam-a-a
fix tests; switch cstr import to watertap cstr which includes hrt; ch…
d8fa554 
…ange asr volumes; eliminate unnecessary code in ASR flowsheet
add metrics
5aa6f63
@luohezhiming
delete BOD5
957f997
@luohezhiming
Merge branch 'main' of https://github.com/watertap-org/watertap
ebd1400
@luohezhiming
Merge branch 'main' into asm3
c28fb2d
@luohezhiming
add metrics and test
d9f8d76
@adam-a-a
Merge branch 'main' into n2o_asp_flowsheet
5f70926
@adam-a-a
Merge remote-tracking branch 'chenyu/asm3' into n2o_asp_flowsheet
1ddde96
@adam-a-a
rename file after adding asm3 compatibility
11c1762
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcusHolly MarcusHolly Awaiting requested review from MarcusHolly MarcusHolly will be requested when the pull request is marked ready for review MarcusHolly is a code owner

@luohezhiming luohezhiming Awaiting requested review from luohezhiming luohezhiming will be requested when the pull request is marked ready for review luohezhiming is a code owner

@agarciadiego agarciadiego Awaiting requested review from agarciadiego agarciadiego will be requested when the pull request is marked ready for review agarciadiego is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adam-a-a @lbianchi-lbl @luohezhiming