Uconn flowsheet with ASM3

watertap/flowsheets/activated_sludge/tests/test_UConn_WRRF.py

@@ -0,0 +1,115 @@
+#################################################################################
+# WaterTAP Copyright (c) 2020-2024, The Regents of the University of California,
+# through Lawrence Berkeley National Laboratory, Oak Ridge National Laboratory,
+# National Renewable Energy Laboratory, and National Energy Technology
+# Laboratory (subject to receipt of any required approvals from the U.S. Dept.
+# of Energy). All rights reserved.
+#
+# Please see the files COPYRIGHT.md and LICENSE.md for full copyright and license
+# information, respectively. These files are also available online at the URL
+# "https://github.com/watertap-org/watertap/"
+#################################################################################
+"""
+Tests for UConn WRRF flowsheet example.
+
+"""
+
+__author__ = "Adam Atia"
+
+import pytest
+
+from pyomo.environ import assert_optimal_termination, value
+from pyomo.util.check_units import assert_units_consistent
+
+from idaes.core.util.model_statistics import degrees_of_freedom
+
+from watertap.flowsheets.activated_sludge.UConn_WRRF import (
+    build_flowsheet,
+    set_operating_conditions,
+    scale_flowsheet,
+    initialize_flowsheet,
+    solve_flowsheet,
+)
+from watertap.flowsheets.activated_sludge.UConn_WRRF import ASMModel
+
+
+class TestUConnFlowsheetASM3:
+    @pytest.fixture(scope="class")
+    def model(self):
+        m = build_flowsheet(asm_model=ASMModel.asm3)
+
+        set_operating_conditions(m, asm_model=ASMModel.asm3)
+        scale_flowsheet(m)
+
+        initialize_flowsheet(m)
+
+        scale_flowsheet(m)
+
+        # res = solve_flowsheet(m)
+
+        # m.results = res
+
+        return m
+
+    @pytest.mark.integration
+    def test_structure(self, model):
+        assert_units_consistent(model)
+        assert degrees_of_freedom(model) == 0
+
+    @pytest.mark.integration
+    def test_solve(self, model):
+        res = solve_flowsheet(model)
+        assert_optimal_termination(res)
+
+    @pytest.mark.integration
+    def test_results(self, model):
+        comps = model.fs.props.solute_set
+        model.fs.Treated.display()
+
+        # Treated water
+        assert value(model.fs.Treated.flow_vol[0]) == pytest.approx(
+            1.06747685185185, rel=1e-4
+        )
+        assert value(model.fs.Treated.temperature[0]) == pytest.approx(288.15, rel=1e-4)
+        assert value(model.fs.Treated.pressure[0]) == pytest.approx(101325, rel=1e-4)
+        assert value(model.fs.Treated.conc_mass_comp[0, "S_I"]) == pytest.approx(
+            30e-3, rel=1e-5
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "S_N2"]) == pytest.approx(
+            0.02888, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "S_NH4"]) == pytest.approx(
+            0.001519, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "S_NOX"]) == pytest.approx(
+            0.007174, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "S_O"]) == pytest.approx(
+            0.00099, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "S_S"]) == pytest.approx(
+            0.00016, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_A"]) == pytest.approx(
+            0.13165, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_H"]) == pytest.approx(
+            1.632358, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_I"]) == pytest.approx(
+            1.46378, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_S"]) == pytest.approx(
+            0.209026, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_S"]) == pytest.approx(
+            0.209026, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_STO"]) == pytest.approx(
+            0.304689, rel=1e-2
+        )
+        assert value(model.fs.Treated.conc_mass_comp[0, "X_TSS"]) == pytest.approx(
+            3.02503, rel=1e-3
+        )
+
+        assert value(model.fs.Treated.alkalinity[0]) == pytest.approx(0.00495, rel=1e-2)

watertap/property_models/unit_specific/activated_sludge/asm1_properties.py

@@ -144,7 +144,7 @@ def build(self):
             domain=pyo.PositiveReals,
             doc="Mass fraction of N per COD in particulates, i_xp",
         )
-        self.COD_to_SS = pyo.Var(
+        self.COD_to_SS = pyo.Param(
             initialize=0.75,
             units=pyo.units.dimensionless,
             domain=pyo.PositiveReals,
@@ -534,6 +534,10 @@ def define_state_vars(self):
 
     def define_display_vars(self):
         return {
+            "TSS": self.TSS,
+            "COD": self.COD,
+            "BOD5": self.BOD5,
+            "TKN": self.TKN,
             "Volumetric Flowrate": self.flow_vol,
             "Molar Alkalinity": self.alkalinity,
             "Mass Concentration": self.conc_mass_comp,