Skip to content

Conversation

@MarcusHolly
Copy link
Contributor

@MarcusHolly MarcusHolly commented Jul 17, 2025

Summary/Motivation:

Develops the activated sludge process model no.2d, which accounts for phosphorus (P), sulfur (S), iron (Fe), and greenhouse gas emission (GHG), but this preliminary model only accounts for P and GHG, so it'll be referred to as the ASM2d-N2O model.

The documentation PR #1598 should be merged first.

Changes proposed in this PR:

  • Adds property and reaction package for ASM2d-N2O
  • Adds testing for the new property and reaction packages
  • Identifies a mistake in the modified ASM2d implementation

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Jul 17, 2025
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 17, 2025
@MarcusHolly MarcusHolly marked this pull request as ready for review July 23, 2025 10:59
Comment on lines 569 to 570
# TODO: Double check these effluent metrics

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this todo- should address or be sure to track in an issue if we decide to handle later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be handled later as they were not mentioned in the c files. I can make educated guesses as to what they might be based on my understanding of the changes I made, but we should find a literature reference to confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants