-
Notifications
You must be signed in to change notification settings - Fork 84
ASM2d-N2O Model Development #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # TODO: Double check these effluent metrics | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this todo- should address or be sure to track in an issue if we decide to handle later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be handled later as they were not mentioned in the c files. I can make educated guesses as to what they might be based on my understanding of the changes I made, but we should find a literature reference to confirm this.
Summary/Motivation:
Develops the activated sludge process model no.2d, which accounts for phosphorus (P), sulfur (S), iron (Fe), and greenhouse gas emission (GHG), but this preliminary model only accounts for P and GHG, so it'll be referred to as the ASM2d-N2O model.
The documentation PR #1598 should be merged first.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: