Skip to content

ASM2d-N2O Model Development #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcusHolly wants to merge 28 commits into
base: main
Choose a base branch
from
Open

ASM2d-N2O Model Development #1605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a3ddf5b
Create documentation for ASM2d-N2O
MarcusHolly Jun 23, 2025
992ce5a
Correct typo
MarcusHolly Jun 24, 2025
add9a33
Correct typo
MarcusHolly Jun 24, 2025
471003a
Add missing parameter values
MarcusHolly Jun 24, 2025
324e0e7
Add properties and parameters
MarcusHolly Jun 25, 2025
d08e5e6
Finish preliminary documentation
MarcusHolly Jun 26, 2025
4410f6c
Update index
MarcusHolly Jun 26, 2025
7f548f9
Update index
MarcusHolly Jun 26, 2025
c68ab7d
Address typos
MarcusHolly Jun 26, 2025
b5790fa
Fix another typo
MarcusHolly Jul 3, 2025
96cac56
Change doc name
MarcusHolly Jul 3, 2025
2602998
Merge branch 'main' into asm2_ghg_doc
MarcusHolly Jul 3, 2025
e31abd1
Correct typo
MarcusHolly Jul 7, 2025
c44cdc9
Minor updates to documentation
MarcusHolly Jul 10, 2025
034b3fa
Create initial property and rxn files
MarcusHolly Jul 10, 2025
86e611c
Update reference temperature
MarcusHolly Jul 16, 2025
0f74a65
Add stoichiometric rxns
MarcusHolly Jul 16, 2025
0da6ebf
Finished initial implementation
MarcusHolly Jul 17, 2025
44c76a4
Correct typo in modified ASM2d reactions
MarcusHolly Jul 17, 2025
becf0f6
Correct modified asm2d reaction test after fixing typo
MarcusHolly Jul 17, 2025
439bc73
add thermo test
MarcusHolly Jul 17, 2025
cfb7af2
Undo correction to modified ASM2d
MarcusHolly Jul 17, 2025
cd8a39a
Begin updating reaction test
MarcusHolly Jul 18, 2025
314d968
Finish initial implementation
MarcusHolly Jul 22, 2025
721d618
Merge branch 'main' into asm2-psfe-ghg
MarcusHolly Jul 23, 2025
2d151a9
Finish updating tests
MarcusHolly Jul 23, 2025
adb6aef
Add clarification to in-line comments
MarcusHolly Jul 31, 2025
a0602f7
Merge branch 'main' into asm2-psfe-ghg
MarcusHolly Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
321 changes: 321 additions & 0 deletions docs/technical_reference/property_models/ASM2D_GHG.rst
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/technical_reference/property_models/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ Property Models
ADM1
modified_ADM1
modified_ASM2D
ASM2D_GHG
mc_aq_sol
17 changes: 14 additions & 3 deletions docs/technical_reference/property_models/modified_ASM2D.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,16 @@ Kinetic Parameters
":blue:`Hydrolysis rate constant`", ":math:`K_H`", "K_H", 2.46, ":math:`\text{day}^{-1}`"
"Anoxic hydrolysis reduction factor", ":math:`hl_{NO3}`", "hl_NO3", 0.6, ":math:`\text{dimensionless}`"
"Anaerobic hydrolysis reduction factor", ":math:`hl_{fe}`", "hl_fe", 0.40, ":math:`\text{dimensionless}`"
"Saturation/inhibition coefficient for oxygen", ":math:`KH_{O2}`", "K_O2", 0.0002, ":math:`\text{kg O_2/}\text{m}^{3}`"
"Saturation/inhibition coefficient for nitrate", ":math:`KH_{NO3}`", "K_NO3", 0.0005, ":math:`\text{kg N/}\text{m}^{3}`"
"Saturation/inhibition coefficient for oxygen", ":math:`KL_{O2}`", "KL_O2", 0.0002, ":math:`\text{kg O_2/}\text{m}^{3}`"
"Saturation/inhibition coefficient for nitrate", ":math:`KL_{NO3}`", "KL_NO3", 0.0005, ":math:`\text{kg N/}\text{m}^{3}`"
"Saturation coefficient for particulate COD", ":math:`KL_{X}`", "KL_X", 0.1, ":math:`\text{kg X_S/}\text{kg X_H}`"
"Saturation/inhibition coefficient for oxygen", ":math:`KH_{O2}`", "KH_O2", 0.0002, ":math:`\text{kg O_2/}\text{m}^{3}`"
"Saturation/inhibition coefficient for nitrate", ":math:`KH_{NO3}`", "KH_NO3", 0.0005, ":math:`\text{kg N/}\text{m}^{3}`"
":blue:`Maximum growth rate on substrate`", ":math:`µ_H`", "mu_H", 4.23, ":math:`\text{kg X_S/}\text{kg X_H . day}`"
":blue:`Maximum rate for fermentation`", ":math:`q_{fe}`", "q_fe", 2.11, ":math:`\text{kg S_F/}\text{kg X_H . day}`"
":blue:`Rate constant for lysis and decay`", ":math:`b_H`", "b_H", 0.28, ":math:`\text{day}^{-1}`"
"Saturation coefficient for growth on SF", ":math:`K_F`", "K_F", 0.004, ":math:`\text{kg COD/}\text{m}^{3}`"
"Saturation coefficient for fermentation of SF", ":math:`K_{fe}`", "K_fe", 0.004, ":math:`\text{d}^{-1}`"
"Saturation coefficient for fermentation of SF", ":math:`K_{fe}`", "K_fe", 0.004, ":math:`\text{kg COD/}\text{m}^{3}`"
"Saturation coefficient for growth on acetate SA", ":math:`KH_A`", "KH_A", 0.004, ":math:`\text{kg COD/}\text{m}^{3}`"
"Saturation coefficient for ammonium (nutrient)", ":math:`KH_{NH4}`", "KH_NH4", 0.00005, ":math:`\text{kg N/}\text{m}^{3}`"
"Saturation coefficient for phosphate (nutrient)", ":math:`KH_{PO4}`", "KH_PO4", 0.00001, ":math:`\text{kg P/}\text{m}^{3}`"
Expand All @@ -147,6 +149,11 @@ Kinetic Parameters
":blue:`Rate for Lysis of X_PAO`", ":math:`b_{PAO}`", "b_PAO", 0.14, ":math:`\text{day}^{-1}`"
":blue:`Rate for Lysis of X_PP`", ":math:`b_{PP}`", "b_PP", 0.14, ":math:`\text{day}^{-1}`"
":blue:`Rate for Lysis of X_PHA`", ":math:`b_{PHA}`", "b_PHA", 0.14, ":math:`\text{day}^{-1}`"
"Saturation coefficient for oxygen", ":math:`KP_{O2}`", "KP_O2", 0.0002, ":math:`\text{kg O_2/}\text{m}^3`"
"Saturation coefficient for nitrate", ":math:`KP_{NO3}`", "KP_NO3", 0.0005, ":math:`\text{kg N/}\text{m}^3`"
"Saturation coefficient for acetate", ":math:`KP_A`", "KP_A", 0.004, ":math:`\text{kg COD/}\text{m}^3`"
"Saturation coefficient for ammonium", ":math:`KP_{NH4}`", "KP_NH4", 0.00005, ":math:`\text{kg N/}\text{m}^3`"
"Saturation coefficient for phosphate for growth", ":math:`KP_{PO4}`", "KP_PO4", 0.00001, ":math:`\text{kg P/}\text{m}^3`"
"Saturation coefficient for phosphorus in storage of PP", ":math:`KP_P`", "KP_P", 0.0002, ":math:`\text{kg P/}\text{m}^3`"
"Saturation coefficient for poly-phosphate", ":math:`KP_{PP}`", "KP_PP", 0.01, ":math:`\text{kg PP/}\text{kg PAO}`"
"Maximum ratio of X_PP/X_PAO", ":math:`K_{MAX}`", "K_MAX", 0.34, ":math:`\text{kg PP/}\text{kg PAO}`"
Expand All @@ -163,6 +170,10 @@ Kinetic Parameters
":lime:`Anoxic reduction factor for decay of PP`", ":math:`hPP_{NO3, end}`", "hPP_NO3_end", 0.33, ":math:`\text{dimensionless}`"
":lime:`Anoxic reduction factor for decay of PHA`", ":math:`hPHA_{NO3, end}`", "hPHA_NO3_end", 0.33, ":math:`\text{dimensionless}`"
":lime:`Anoxic reduction factor for decay of autotrophs`", ":math:`hAUT_{NO3, end}`", "hAUT_NO3_end", 0.33, ":math:`\text{dimensionless}`"
"Saturation/inhibition coefficient for oxygen", ":math:`KA_{O2}`", "KA_O2", 0.0005, ":math:`\text{kg O_2/}\text{m}^{3}`"
"Saturation/inhibition coefficient for ammonium", ":math:`KA_{NH4}`", "KA_NH4", 0.001, ":math:`\text{kg N/}\text{m}^{3}`"
"Saturation/inhibition coefficient for phosphate", ":math:`KA_{PO4}`", "KA_PO4", 0.00001, ":math:`\text{kg P/}\text{m}^{3}`"
"Saturation/inhibition coefficient for nitrate", ":math:`KA_{NO3}`", "KA_NO3", 0.0005, ":math:`\text{kg N/}\text{m}^{3}`"

Properties
----------
Expand Down
Loading
Loading